-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore AclAwareAmazonS3AdapterFactory #284
Conversation
This doesn't work because I was forced to open the PR against the master branch. |
e85c9ec
to
11bc9ac
Compare
i have the same situation, i wait for update, thanks |
@PedroTroller I'm really sorry to bump here, but almost two months passed and I really need this fix. As I suggested before, this PR can be easily reviewed (and hopefully merged) as soon as we have the proper branch. |
@garak I created you a v0.7.x branch matching the latest commit included in the v0.7.2 release. What you did is fine with me, I let you rebase and, once done, I will review and merge 😉 |
Thank you. |
We can't because v0.7.x was running on Travis CI and that's not working anymore. |
Thanks for the help @alexpozzi but it seems it doesn't work. |
My wild guess: https://github.com/KnpLabs/KnpGaufretteBundle/blob/master/.github/workflows/ci.yml#L7 states that only PRs to master trigger the CI. |
I've added the https://github.com/KnpLabs/KnpGaufretteBundle/tree/v0.7.x/.github/workflows/cy.yml (I forgot a trailing s in the workflow folder). I think that now (if you rebase again) it should trigger the ci. |
4e6469c
to
5411c5e
Compare
I can't make it work, unfortunately. Can it be considered enough? After all, this is a really simple PR, not changing much. |
OK, I've found a way to fix all the CI problems on the v0.7.x branch, you can see the passing action here https://github.com/garak/KnpGaufretteBundle/actions/runs/11878238711 So, even if the action is not applied here, I'm confident everything should be green after the merge. |
Thank you! |
Fix #283 by restoring the removed class.
If merged, this change should be released in the 0.7 line, e.g. as v0.7.3