Localization loading randomly breaks when using requirejs

[davhdavh]

It is not currently possible to configure a general requirejs dependency rule that covers all current and future localizations, and since the localization only tells requirejs it depends on knockout, the loading randomly breaks.

[crissdev]

Can you provide more information about your use case? Consider usin http://plnkr.co/ to create an example - to better explain your issue.

[viceice]

I found the error!

The localization files should require knockout.validaion not knockout.

That's why requirejs sometimes initialize the localization before knockout.validation.

Regards,
Michael

[crissdev]

Thanks Michael.

Great to see the module ID you sugget is knockout.validation and not with a hyphen. This is something that will be implemented in a future version of the library.

[crissdev]

@viceice do you want to submit a PR for this?

[viceice]

If you want, i can do this.

[crissdev]

Sure, go ahead. Thanks.

[viceice]

Ok, give me some minutes. :-)

[crissdev]

Reopening this issue because some localization files were not refactored.

[viceice]

Which files?

[viceice]

Oh. I see it. eg: localization/pl-PL.js#L6

I missed the the globals. I will check this

[crissdev]

Thanks @viceice for your interest on this. It seems there's more to fix than some AMD loading - somehow I missed that localization messages are not exported for nodejs when I first worked on it.

[viceice]

Ok, haven't used it with node. Maybe some tests are required.

Anything i can do?

[crissdev]

No worrries, I already started on this - there's only the fix for nodejs left. But thanks.

[viceice]

Ok, no problem. 👍