Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M204 with Super Slicer not working #3908

Closed
markwinger opened this issue Feb 9, 2021 · 9 comments
Closed

M204 with Super Slicer not working #3908

markwinger opened this issue Feb 9, 2021 · 9 comments
Labels

Comments

@markwinger
Copy link

I have been trying to use super slicer the last few days (was using cura). I got things setup prettey well and printeed a test printer. I did a few other things then reprinted the same object without making any changes to the slicer. When printing the second time it had taken about twice as much time with 30% to go. I could tell my listening to the printer that acceleration was much slower. I noticed the following error on the console:
Invalid M204 command "M204 P3500 ; adjust acceleration"

The klipper doumentation of gcode says that if the "Note: If S is not specified and both P and T are specified, then the acceleration is set to the minimum of P and T. If only one of P or T is specified, the command has no effect."
I typed M204 P3500 T3500 in the console and the speed jumped way up.
Looking an the marlin documention on gcode it says "Legacy M204 S is deprecated. Use separate paremeters M204 P T instead.". Usage says: "M204 [P] [R] [S] [T]"

This implies to me that M204 S changed both print and travel acceleration. To get the same behavior use M204 P T. But it does not say that you must include both P<> and T<> for the command to be valid.

I suspect that since super slicer is a fork of prusa slicer and slic3r, the they my have the same problem.

I think klipper ignoring the M204 P<> command is a mistake in kilpper. Either way it is in conflict with some slicers so I believe this is a but in klipper.

klippy.log

@jakep82
Copy link
Collaborator

jakep82 commented Feb 9, 2021

This behavior is documented. https://www.klipper3d.org/G-Codes.html

Set acceleration: M204 S<value> OR M204 P<value> T<value>

Note: If S is not specified and both P and T are specified, then the acceleration is set to the minimum of P and T. If only one of P or T is specified, the command has no effect.

@markwinger
Copy link
Author

You quoted the same thing I quoted from the klipper g-code documentaion. Klipper IS working as designed based on that. But Marlin docs say this is wrong. If klippers interpretation is correct, usage would be defined more like:

M204 [P T] [S] [R<accel]

This would say P and T must be used together.

But marlin spec says:

Usage: M204 [P] [R] [S] [T]

Which specifically says all options are optional, P and T are not required to be supplied together.

These two interpretations are not compatible.....so slicers that follow the specified usage as super slicer does, will not work correcly with klipper...
What I am saying is that klippers interpretation will not work with some slicers unless the slicers all change to follow klippers interpretation of marlin.

Is there is some other spec was used that Marlin, super slicer, prusa slicer,... should have used that implies that they interpreted this incorrectly?
Am I missing something or looking at this all wrong???

@KevinOConnor KevinOConnor added the not on github Not a topic tracked on github label Feb 9, 2021
@github-actions
Copy link

github-actions bot commented Feb 9, 2021

Unfortunately, it appears the directions at https://www.klipper3d.org/Contact.html were not followed for this issue.

We choose to use github as a place that people working on improving Klipper can share the results of their work. We choose to not use github to help diagnose problems with a user's printer. We choose to not use github to answer user questions. We choose to not use github as a place to make requests.

In the future, please follow the directions at: https://www.klipper3d.org/Contact.html
This ticket will be automatically closed.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@KevinOConnor KevinOConnor removed the not on github Not a topic tracked on github label Feb 9, 2021
@jakep82
Copy link
Collaborator

jakep82 commented Feb 9, 2021

Klipper is not Marlin. This is the documented and intended behavior for Klipper.

@KevinOConnor
Copy link
Collaborator

Ah, thinking about this further, I'm going to remove the "invalid" label. I understand your report, but I do not agree this is a defect in Klipper. It is not a goal of Klipper to be compatible with Marlin. The goal of Klipper's g-code support is to be compatible with slicers in their standard configurations - slicer based acceleration control is not a requirement to use a slicer (nor is it particularly useful in my opinion).

-Kevin

@Sineos
Copy link
Collaborator

Sineos commented Feb 9, 2021

@Hywelmartin
Copy link
Contributor

Hywelmartin commented Feb 9, 2021

superslicer klipper as G-code flavor.... for other Slic3r derivatives I use RepRap/sprinter
bild

slicer based acceleration control is not a requirement to use a slicer (nor is it particularly useful in my opinion).

I disagree with you on the usefulness @KevinOConnor
bridges gain on lower and travel on higher..

@markwinger
Copy link
Author

I know its not marlin. But in the slicers page of your docs ( https://www.klipper3d.org/Slicers.html ) it says Many slicers have an option to configure the “G-Code flavor”. The default is frequently “Marlin” and that works well with Klipper.

Thanks Hywelmartin. I had not seen where firmware flavor was setup. I changed it to klipper and it generates M204 S where as marlin flavor generates M204 P.

Sorry for my mistake.

@github-actions
Copy link

github-actions bot commented Mar 3, 2021

Hello,

It looks like there hasn't been any recent updates on this
Klipper github issue. If you created this issue and no
longer consider it open, then please login to github and
close the issue. Otherwise, if there is no further activity
on this thread then it will be automatically closed in a few
days.

Best regards,

~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot added the Stale label Mar 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants