Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: missing lint settings #1

Open
PartyLich opened this issue Jul 27, 2020 · 0 comments
Open

style: missing lint settings #1

PartyLich opened this issue Jul 27, 2020 · 0 comments

Comments

@PartyLich
Copy link

Trivial first issue: add a lint config

It's not a huge deal right now, but enforcing consistent code conventions is always a good idea. For example, the current index.js has inconsistent use of semicolons, indents, and quotes. Not a breaking thing, but it's the first thing that jumped out to me when i opened the file.

I'm happy to add an eslint setup, I just don't know what conventions you'd like to adopt. All semis, only essential semis? 2 space indents (the most common js convention ive seen), 4 (to be consistent with the C codebase elsewhere). etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant