Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X tags of VR == 'DA' not getting deleted #56

Open
smjoshiatglobus opened this issue Nov 8, 2023 · 3 comments
Open

X tags of VR == 'DA' not getting deleted #56

smjoshiatglobus opened this issue Nov 8, 2023 · 3 comments
Assignees

Comments

@smjoshiatglobus
Copy link
Contributor

smjoshiatglobus commented Nov 8, 2023

I found this while looking at pytest failures for "color3d_jpeg_baseline.dcm" file from pydicom's test files. The element (0020,0244) was not getting deleted. The tag is listed in X_TAGS.

The code for delete_element calls replace_element_date for VR=='DA', even if the element is supposed to be deleted. I cannot figure out why that is all right. Please help!

In addition to 'X', I see 'K' and 'C' listed in that row of PS 3.15: Table E-1.1. What do these mean?

@smjoshiatglobus
Copy link
Contributor Author

I found Section E.3.6. Note 2 in that section says that it is all right to set dummy values for dates. Is that the rationale behind this code logic?

@pchoisel
Copy link
Collaborator

That's a good point, I can also see the issue now that we merged #60
I will investigate

@smjoshiatglobus
Copy link
Contributor Author

smjoshiatglobus commented Jan 26, 2024

PR #64 does not fix this issue, just puts in temporary exclusion of elements of type DA. This has enabled testing of all other tags for test files that were originally failing the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants