Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: access to EventLoopGroup #224

Closed
mlilback opened this issue Sep 28, 2019 · 4 comments
Closed

Feature Request: access to EventLoopGroup #224

mlilback opened this issue Sep 28, 2019 · 4 comments
Assignees

Comments

@mlilback
Copy link

According to documentation, an application should generally have a single EventLoopGroup. Kitura-NIO create its own group and threads, and provides no access. Performance will suffer if every library used creates its own group.

I'd like the options:

  1. To create my own group, and pass it into Kitura.
  2. If a group is not specified and Kitura creates one, n accessor to get that group.
@weissi
Copy link

weissi commented Sep 28, 2019

I agree, especially option 1 sounds like a good plan to me. In async-http-client for example there’s the EventLoopGroupProvider type to do this.

@pushkarnk
Copy link
Contributor

Sounds reasonable to me. We'd be deviating from the Kitura-net API, but I assume that developers who want to use NIO's types may not really consider switching over to Kitura-net.

Your thoughts @djones6 ?

@harish1992 harish1992 self-assigned this Oct 1, 2019
@djones6
Copy link
Contributor

djones6 commented Oct 2, 2019

I think that deviation from Kitura-net is okay in this instance. As long as the expectation is clear that the application is then tightly coupled to Kitura-NIO, I don't see a problem with providing additional features such as this.

@harish1992
Copy link
Contributor

Hi @mlilback, PR #225 adds this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants