From 0d911643601552de751025bcb04689c9217d3f6a Mon Sep 17 00:00:00 2001 From: Pushkar Kulkarni Date: Mon, 24 Sep 2018 18:42:02 +0000 Subject: [PATCH] Do not store the HTTPDummyServerDelegate object Kitura-Net keeps the HTTP server running even if a delegate isn't provided. We use a HTTPDummyServerDelegate for this purpose. Before this code change, we stored the dummy delegate in the delegate property of HTTPServer. This may be confusing to a user who will rightly think that delegate is nil if it isn't explicitly set. --- Sources/KituraNet/HTTP/HTTPServer.swift | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Sources/KituraNet/HTTP/HTTPServer.swift b/Sources/KituraNet/HTTP/HTTPServer.swift index f1ab0dd7..e6fd4817 100644 --- a/Sources/KituraNet/HTTP/HTTPServer.swift +++ b/Sources/KituraNet/HTTP/HTTPServer.swift @@ -164,10 +164,6 @@ public class HTTPServer : Server { upgraders.append(upgrader) } - if self.delegate == nil { - self.delegate = HTTPDummyServerDelegate() - } - let bootstrap = ServerBootstrap(group: eventLoopGroup) .serverChannelOption(ChannelOptions.backlog, value: BacklogOption.OptionType(self.maxPendingConnections)) .serverChannelOption(ChannelOptions.socket(SocketOptionLevel(SOL_SOCKET), SO_REUSEADDR), value: 1)