Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Two bug #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Two bug #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef26490
anim.removedOnCompletion = YES;
Dec 10, 2015
8dae231
isEqualToString not isEqual
Dec 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions KYAnimatedPageControl-Demo/Classes/KYSpringLayerAnimation.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ -(CAKeyframeAnimation *)createBasicAnima:(NSString *)keypath duration:(CFTimeInt
anim.values = [self basicAnimationValues:fromValue toValue:toValue duration:duration];
anim.duration = duration;
anim.fillMode = kCAFillModeForwards;
anim.removedOnCompletion = NO;
anim.removedOnCompletion = YES;

return anim;
}
Expand All @@ -45,7 +45,7 @@ -(CAKeyframeAnimation *)createSpringAnima:(NSString *)keypath duration:(CFTimeIn
anim.values = values;
anim.duration = duration;
anim.fillMode = kCAFillModeForwards;
anim.removedOnCompletion = NO;
anim.removedOnCompletion = YES;

return anim;
}
Expand All @@ -56,7 +56,7 @@ -(CAKeyframeAnimation *)createCurveAnima:(NSString *)keypath duration:(CFTimeInt
anim.values = [self curveAnimationValues:fromValue toValue:toValue duration:duration];
anim.duration = duration;
anim.fillMode = kCAFillModeForwards;
anim.removedOnCompletion = NO;
anim.removedOnCompletion = YES;

return anim;
}
Expand All @@ -68,7 +68,7 @@ -(CAKeyframeAnimation *)createHalfCurveAnima:(NSString *)keypath duration:(CFTim
anim.values = [self halfCurveAnimationValues:fromValue toValue:toValue duration:duration];
anim.duration = duration;
anim.fillMode = kCAFillModeForwards;
anim.removedOnCompletion = NO;
anim.removedOnCompletion = YES;

return anim;

Expand Down
2 changes: 1 addition & 1 deletion KYAnimatedPageControl-Demo/Classes/Line.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ -(void)setSelectedPage:(NSInteger)selectedPage{

#pragma mark -- override Class func
+ (BOOL)needsDisplayForKey:(NSString *)key{
if ([key isEqual: @"selectedLineLength"]) {
if ([key isEqualToString: @"selectedLineLength"]) {
return YES;
}
return [super needsDisplayForKey:key];
Expand Down