Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading from string instead of file path #183

Closed
pascalberger opened this issue Aug 2, 2018 · 7 comments
Closed

Support reading from string instead of file path #183

pascalberger opened this issue Aug 2, 2018 · 7 comments

Comments

@pascalberger
Copy link
Contributor

It would be nice if there would be an overload of BinaryLogReplayEventSource.ReadRecords which accepts a string instead of a file path, for cases where the log file content is already available in memory.

@KirillOsenkov
Copy link
Owner

string is not binary (it has encoding), but I can certainly imagine Stream and byte[]. Would that work?

@pascalberger
Copy link
Contributor Author

This would definitely help. Would be great to have this possibility for reading .binlog, .buildlog and .xml files.

@KirillOsenkov
Copy link
Owner

How's this change?
b06d2ce

Would you please build it yourself and try it out? If it works fine, I can publish the next update.

@pascalberger
Copy link
Contributor Author

@KirillOsenkov Thanks! Works fine for my use case

@KirillOsenkov
Copy link
Owner

@pascalberger
Copy link
Contributor Author

@KirillOsenkov Do you have any plans to update the NuGet package to a recent version, or is there a specific reason why it is still at 1.1.224?

@KirillOsenkov
Copy link
Owner

Microsoft has introduced additional security requirements to publish NuGet packages under Microsoft.*. There's a few hoops I'd need to jump through, like signing, internal security groups, etc.

I don't have time nowadays for that, but I am aware that the NuGet packages are behind and want to fix this as soon as I have time. I apologize for the inconvenience. I'll either find time to set up upload infrastructure again or move to a non-Microsoft package id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants