Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add release notes file check to release process #1034

Open
3 of 6 tasks
CalvinWilkinson opened this issue Sep 17, 2024 · 0 comments
Open
3 of 6 tasks

🚧Add release notes file check to release process #1034

CalvinWilkinson opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
cicd CI/CD and workflow related work only high-priority High Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Sep 17, 2024

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Add a check in the release workflow/process to ensure the release notes file exists before publishing a Nuget package and creating a release.

This check should happen early in the workflow.

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

ToDo Items

The items to complete to satisfy the Definition of Done.

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking-changes
New Feature ✨new-feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added cicd CI/CD and workflow related work only high-priority High Priority preview Done while in preview labels Sep 17, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.39 milestone Sep 17, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Sep 17, 2024
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Sep 17, 2024
@CalvinWilkinson CalvinWilkinson added api-changes Changes to the public API and removed api-changes Changes to the public API labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd CI/CD and workflow related work only high-priority High Priority preview Done while in preview
Projects
Status: ⚪Not Set
Development

No branches or pull requests

1 participant