Add no_response_threshold(120s) for No response requests #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hocktea214
force-pushed
the
add-noresponse-threshol
branch
from
4a10d02 to
75d1696
Compare
hocktea214
changed the title
dxsup
reviewed
Dec 1, 2022
dxsup
reviewed
Dec 1, 2022
Signed-off-by: huxiangyuan <[email protected]>
…as 2min. Signed-off-by: huxiangyuan <[email protected]>
Signed-off-by: huxiangyuan <[email protected]>
hocktea214
force-pushed
the
add-noresponse-threshol
branch
from
bcd17fc to
a34aaee
Compare
Signed-off-by: huxiangyuan <[email protected]>
Signed-off-by: huxiangyuan <[email protected]>
dxsup
approved these changes
Dec 1, 2022
NeJan2020
pushed a commit
to NeJan2020/kindling
that referenced
this pull request
May 4, 2023
…ject#376) Signed-off-by: Daxin Wang <[email protected]> Signed-off-by: niejiangang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: huxiangyuan [email protected]
Description
There're two checks for no response request and completed request with same 15s check.
In fact, complete request should check timely with 15s
But the no response request should wait long period with 120s which is set with no_response_threshold in config file.
Besides, there may be multi-send with same request, use atomic check for send once.
Related Issue
Motivation and Context
How Has This Been Tested?