Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V0.96.8] carry ressource crates #813

Merged
merged 13 commits into from
Oct 28, 2023
Merged

[V0.96.8] carry ressource crates #813

merged 13 commits into from
Oct 28, 2023

Conversation

Dubjunk
Copy link
Contributor

@Dubjunk Dubjunk commented Jul 10, 2020

Q A
Bug fix? no
New feature? yes
Needs wipe? no

Description:

This PR adds the ability to carry ressource crates without using ACE.

Content:

  • Ressource crate carrying

Successfully tested on:

  • Local MP
  • Dedicated MP

@Dubjunk Dubjunk self-assigned this Jul 10, 2020
@Dubjunk Dubjunk added the enhancement New feature or request label Jul 10, 2020
@Dubjunk Dubjunk added this to the v0.96.8 milestone Jul 10, 2020
@Dubjunk Dubjunk requested review from Wyqer and veteran29 July 10, 2020 08:10
@Dubjunk Dubjunk marked this pull request as ready for review September 23, 2020 07:53
@Dubjunk Dubjunk requested a review from Wyqer September 30, 2020 19:35
@Dubjunk
Copy link
Contributor Author

Dubjunk commented Sep 30, 2020

I've made another local test and found some more little bugs, generally it works as intended but there's still a simulation problem when detaching crates. Sometimes they randomly hang up in he air in the position they were dropped, fixes itself when another crate is moved in any way.

Apricot-ale added a commit to Apricot-ale/KP-Liberation-APR that referenced this pull request Feb 28, 2023
@Apricot-ale
carry ressource crates
bd6ba4e 
KillahPotatoes#813
Apricot-ale added a commit to Apricot-ale/KP-Liberation-APR that referenced this pull request Mar 2, 2023
@Apricot-ale
carry ressource crates
1a02538 
KillahPotatoes#813
@veteran29 veteran29 removed the request for review from Wyqer October 28, 2023 18:40
veteran29
veteran29 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixed floating crates and prevented players from putting them inside vehicles or driving while carrying.

@veteran29 veteran29 dismissed Wyqer’s stale review October 28, 2023 18:41

Stale review

@veteran29 veteran29 merged commit 4b5ed81 into v0.96.8 Oct 28, 2023
1 check passed
@veteran29 veteran29 deleted the v0.96.8-carry_ressouce_crates branch October 28, 2023 18:43
@veteran29
Copy link
Member

Closes #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

@Wyqer Wyqer Wyqer left review comments

Assignees

@Dubjunk Dubjunk

Labels
enhancement New feature or request
Projects
KP Liberation
Status: Done
Milestone
v0.96.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Dubjunk @veteran29 @Wyqer