Build module - basic resource payment #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial load via 3DEN is not seen as 3DEN multiplayer during parsing time
New version of command since 1.92
|
@KillahPotatoes/kplib-testers open for testing. Also needs testing on dedi, I'm out of home till end of week. |
Wyqer
requested changes
May 3, 2019
There was a problem hiding this comment.
Only some smaller things, nothing critical. Some coding convention stuff (variable naming, function calling).
I've also seen that you've in the preInit KPLIB_buildLogic, should also be KPLIB_build_XYZ.
As soon as you've added the missing stringtable keys, I'll add the German strings again. By the way, why not directly adding Polish strings?
Missionframework/modules/15_build/fnc/fn_build_displayPlaceObject.sqf
Outdated
Show resolved
Hide resolved
Dubjunk
requested changes
May 3, 2019
Co-Authored-By: veteran29 <[email protected]>
Co-Authored-By: veteran29 <[email protected]>
Co-Authored-By: veteran29 <[email protected]>
Wyqer
approved these changes
May 4, 2019
Dubjunk
approved these changes
May 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Very basic implementation of resource payment in build module. To be improved as some sort of build queue in future.
Additional fixes done by the way.
Content:
Successfully tested on:
Compatibility checked with: