Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function headers overhaul #525

Merged
merged 13 commits into from
Nov 12, 2018
Merged

Function headers overhaul #525

merged 13 commits into from
Nov 12, 2018

Conversation

Dubjunk
Copy link
Contributor

@Dubjunk Dubjunk commented Nov 11, 2018

Q A
Bug fix? no
New feature? no
Needs wipe? no
Fixed issues #515

Description:

All function headers are overhauled and all params are defined as precise as possible.
Now the function tooltips should be properly displayed and function calls without arguments or wrong arguments will be overwritten by the defaultValue and dataType definitions.

Content:

  • Refactor all function headers accordingly
  • Refactor all param arrays
  • Update the psioniq File Header template

Successfully tested on:

  • Local MP Vanilla
  • Dedicated MP Vanilla

Compatibility checked with:

  • Not needed

@Dubjunk Dubjunk added this to the Sprint 8 milestone Nov 11, 2018
@Dubjunk Dubjunk requested review from Wyqer and veteran29 November 11, 2018 21:06
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already discussed in Discord it seems all fine.
And as you've tested everything there shouldn't happen errors due to param default value changes.
But it's of course something we need to rethink in some cases if switching from something like nil to the zeroPos for a position argument could be something which makes it harder to debug as it won't throw an error and just dump/create something at the corner of the map under the water surface.
Overall it looks good to me and the mentioned default value changes would be something we can easily adjust when we encounter some unwanted behaviour.

@Dubjunk Dubjunk merged commit 033c726 into v0.97S8 Nov 12, 2018
@Dubjunk Dubjunk deleted the v0.97S8-515 branch November 12, 2018 14:05
@Dubjunk Dubjunk added done and removed review/QA labels Nov 12, 2018
@Wyqer Wyqer mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants