-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBA Settings implementation #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice, I like the implementation of the CBA settings.
Found nothing critical, good work!
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it should be all fine.
320bb06
to
95e7d4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Third try :)
Description:
All mission parameters are deleted, as the mission configuration is now implemented via the CBA Settings system. Due to this change, the
wipe
functionality is moved to the server admin dialog. As it's kind of possible that people could click the "wipe save" button by mistake or to "try it", the current save data will be exported to the players profile, before the server wipes all his save data. This way the player can just import the save data again to undo the save wipe. A server/mission restart has to be done in both cases.The big benefit by using CBA Settings is the possible modularity. Every module can now add their own CBA settings without the need to touch any of the existing files. Furthermore the whole "persistent parameters" functionality is now obsolete, as it's part of the CBA Settings system.
Furthermore I've completely cleaned and recategorized the stringtable.xml. I've also added a tag to the strings, as we didn't had one since now. This is to ensure there won't be any issues with mods etc. which are also using an own stringtable.
All modules are now also contain a readme.md file with an overview about the module functionality and a list of all included functions.
Content:
Successfully tested on:
Compatibility checked with: