Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBA Settings implementation #524

Merged
merged 16 commits into from
Nov 12, 2018
Merged

CBA Settings implementation #524

merged 16 commits into from
Nov 12, 2018

Conversation

Wyqer
Copy link
Member

@Wyqer Wyqer commented Nov 11, 2018

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues #514

Description:

All mission parameters are deleted, as the mission configuration is now implemented via the CBA Settings system. Due to this change, the wipe functionality is moved to the server admin dialog. As it's kind of possible that people could click the "wipe save" button by mistake or to "try it", the current save data will be exported to the players profile, before the server wipes all his save data. This way the player can just import the save data again to undo the save wipe. A server/mission restart has to be done in both cases.

The big benefit by using CBA Settings is the possible modularity. Every module can now add their own CBA settings without the need to touch any of the existing files. Furthermore the whole "persistent parameters" functionality is now obsolete, as it's part of the CBA Settings system.

Furthermore I've completely cleaned and recategorized the stringtable.xml. I've also added a tag to the strings, as we didn't had one since now. This is to ensure there won't be any issues with mods etc. which are also using an own stringtable.

All modules are now also contain a readme.md file with an overview about the module functionality and a list of all included functions.

Content:

  • Removed mission parameters
  • Cleaned the KPLIB_config.sqf
  • Created a backup of the old config file
  • Implemented all currently used/needed settings as CBA settings
  • Sorted all CBA settings to corresponding module settings (currently just init and respawn)
  • Added strings for the CBA settings to the stringtable
  • Cleaned and resorted the whole stringtable and added a tag
  • Adjusted all files concerning the new settings variables/strings
  • Added module description readmes to each module root folder
  • Moved save wipe from mission parameters to the admin menu
  • Changelog update

Successfully tested on:

  • Local MP Vanilla
  • Dedicated MP Vanilla

Compatibility checked with:

  • Wasn't necessary

@Wyqer Wyqer added this to the Sprint 8 milestone Nov 11, 2018
@Wyqer Wyqer requested review from veteran29 and Dubjunk November 11, 2018 20:10
Dubjunk
Dubjunk previously approved these changes Nov 11, 2018
Copy link
Contributor

@Dubjunk Dubjunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, I like the implementation of the CBA settings.
Found nothing critical, good work!

veteran29
veteran29 previously approved these changes Nov 12, 2018
@veteran29
Copy link
Member

lgtm

Dubjunk
Dubjunk previously approved these changes Nov 12, 2018
Copy link
Contributor

@Dubjunk Dubjunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be all fine.

Copy link
Contributor

@Dubjunk Dubjunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third try :)

@Wyqer Wyqer merged commit c1762de into v0.97S8 Nov 12, 2018
@Wyqer Wyqer deleted the v0.97S8-514 branch November 12, 2018 16:32
@Wyqer Wyqer added done and removed review/QA labels Nov 12, 2018
@Wyqer Wyqer mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants