Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] State colours for toggles #23

Closed
trankillity opened this issue Jan 11, 2021 · 12 comments
Closed

[Request] State colours for toggles #23

trankillity opened this issue Jan 11, 2021 · 12 comments

Comments

@trankillity
Copy link

Love this theme, but I can't use it because the state colour for on and off seem to be the same. Would be great to have a different colour for off so that the icons can properly tint when you toggle states.

@thatkookooguy
Copy link
Member

Can you explain what you mean? Maybe a screenshot even?

Are you talking about toggles? Because for me that do have two different colors

@trankillity
Copy link
Author

Sure, I should have been more explicit sorry. It's for button cards and full icon state display of automations/groups only. It looks like most other entities represent on/off correctly.

Steps to reproduce:

  1. Add button card selecting an automation or group domain entity
  2. Toggle on/off
  3. Note that state colour does not change

@thatkookooguy
Copy link
Member

cool! will try to debug this this weekend and hopefully add a fix

@chieft8
Copy link

chieft8 commented Jan 15, 2021

I just setup this theme last week and have the same problem. I was not sure if it was just how it was made or a bug, but state colors do not change when the states change. I have double checked I have the setting on in Lovelace. If I dim a light, the light icon will dim, but if motion is detected, the color will not change.

Again, not sure if bug or not. I would like to change the color baed on state if there is a way.

@thatkookooguy
Copy link
Member

@brumfieldtate talking about the same card @trankillity talked about? can you send me what card you're talking about?
I'll try and check your scenario on the weekend as well

@chieft8
Copy link

chieft8 commented Jan 15, 2021

@brumfieldtate talking about the same card @trankillity talked about? can you send me what card you're talking about?
I'll try and check your scenario on the weekend as well

Thanks for the response. My Mistake I should have specified. I was referring to the glance card. Here is an image. As you can see the icon does change based on state but color does not. Not sure if this is a bug or not. Same goes as for Button cards, I have lights that when on, the color/icon does not change.

Thanks

Edit: I went ahead and added a toggle card, for me the color does change based on state. So perhaps the button & glance cards are not bugs. Sorry

@anubisg1
Copy link

Yes PLEASE! i also would like this feature to be supported...

this is a screenshot of what it means:

Bulbs turned ON are yellow, the ones turned OFF are that blue color

image
image

@charis0728
Copy link

Same here.
I wish this bug could be resolved ASAP.
So beautiful theme!
Thank you for sharing it. @thatkookooguy

@charis0728
Copy link

charis0728 commented Jan 29, 2021

@brumfieldtate @trankillity @anubisg1
I solve this problem on my own.
Just change the color of 'state-icon-active-color:' '#FFF' to 'rgba(255, 214, 10, 1)' in kibibit.yaml.

state-icon-active-color: rgba(255, 214, 10, 1)

@anubisg1
Copy link

yeah, it's even commented there :D

@thatkookooguy
Copy link
Member

lol sorry, guys! I had a rough couple of weeks so didn't have a chance to check this out.

thx @charis0728 for finding the problem! I'll fix it right now

@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants