Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.224.0: install path of cmake files #3008

Closed
kloczek opened this issue Aug 23, 2022 · 4 comments
Closed

1.3.224.0: install path of cmake files #3008

kloczek opened this issue Aug 23, 2022 · 4 comments
Assignees

Comments

@kloczek
Copy link

kloczek commented Aug 23, 2022

Just updated my glslang rpm package and found that new version provides cmake module.

    File not found: /home/tkloczko/rpmbuild/BUILDROOT/glslang-1.3.224.0-2.fc35.x86_64/usr/include/SPIRV
    Installed (but unpackaged) file(s) found:
   /usr/share/glslang/glslang-config-version.cmake
   /usr/share/glslang/glslang-config.cmake
   /usr/share/glslang/glslang-targets-relwithdebinfo.cmake
   /usr/share/glslang/glslang-targets.cmake

Those files should be installed in $(libdir)/cmake/glslang

@jeremy-lunarg
Copy link
Contributor

This sounds like an RPM package maintenance issue. Can you file an issue with the package maintainer?

@jeremy-lunarg jeremy-lunarg self-assigned this Aug 25, 2022
@kloczek
Copy link
Author

kloczek commented Aug 25, 2022

So you want to say that you don;t knoiw what are the base paths in which cmake is looking for modules?

@jeremy-lunarg
Copy link
Contributor

Please take a look at #3009. Let me know if it addresses this issue. Thanks.

@kloczek
Copy link
Author

kloczek commented Aug 26, 2022

This PR still is incorrect.
Everywhere should be s/${CMAKE_INSTALL_LIBDIR}/${PROJECT_NAME}/${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}/
Base directory where cmake is lookimng for modules in subdirectories is $(libdir)/cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants