Windows Compile error with Chromium/ANGLE after "IsNan and IsInfinity for parse-time constant folding"

[null77]

Compile error:

FAILED: obj/src/tests/angle_deqp_khr_common/glcSpirvUtils.obj 
C:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe /c ../../third_party/VK-GL-CTS/src/external/openglcts/modules/common/glcSpirvUtils.cpp /Foobj/src/tests/angle_deqp_khr_common/glcSpirvUtils.obj /nologo /showIncludes:user /winsysroot../../third_party/depot_tools/win_toolchain/vs_files/3bda71a11e -DUSE_AURA=1 "-DCR_CLANG_REVISION=\"llvmorg-14-init-8564-g34b903d8-2\"" -DCOMPONENT_BUILD -D_LIBCPP_ABI_UNSTABLE -D_LIBCPP_ENABLE_NODISCARD -D_LIBCPP_NO_AUTO_LINK -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DNTDDI_VERSION=NTDDI_WIN10_VB -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DANGLE_IS_WIN -DDEQP_SUPPORT_GLES31=1 -DDEQP_SUPPORT_GLES3=1 -DDEQP_SUPPORT_GLES2=1 -DDEQP_SUPPORT_EGL=1 "-DDEQP_TARGET_NAME=\"angle\"" -DDEQP_GLES31_RUNTIME_LOAD=1 -DDEQP_GLES3_RUNTIME_LOAD=1 -DDEQP_GLES2_RUNTIME_LOAD=1 -DQP_SUPPORT_PNG=1 -D_HAS_EXCEPTIONS=1 -D_MBCS "-DANGLE_DEQP_DATA_DIR=\"gen/vk_gl_cts_data/data\"" -D_CRT_NONSTDC_NO_WARNINGS -D_WINSOCK_DEPRECATED_NO_WARNINGS -I../../third_party/VK-GL-CTS/src/external/vulkancts/framework/vulkan -I../../buildtools/third_party/libc++ -I../../include -I../../src -I../../third_party/VK-GL-CTS/src/external/openglcts/modules/common -I../../third_party/VK-GL-CTS/src/external/openglcts/modules/gl -I../../third_party/VK-GL-CTS/src/external/openglcts/modules/gles2 -I../../third_party/VK-GL-CTS/src/external/openglcts/modules/gles3 -I../../third_party/VK-GL-CTS/src/external/openglcts/modules/gles31 -I../../third_party/VK-GL-CTS/src/external/openglcts/modules/gles32 -I../../third_party/VK-GL-CTS/src/external/openglcts/modules/glesext -I../../third_party/VK-GL-CTS/src/framework/egl -I../../third_party/VK-GL-CTS/src/framework/egl/wrapper -I../../third_party/VK-GL-CTS/src/framework/opengl -I../../third_party/VK-GL-CTS/src/framework/opengl/simplereference -I../../third_party/VK-GL-CTS/src/framework/opengl/wrapper -I../../third_party/VK-GL-CTS/src/framework/common -I../../third_party/VK-GL-CTS/src/framework/randomshaders -I../../third_party/VK-GL-CTS/src/framework/referencerenderer -I../../third_party/VK-GL-CTS/src/executor -I../../third_party/VK-GL-CTS/src/execserver -I../../third_party/VK-GL-CTS/src/framework/platform/null -I../../third_party/VK-GL-CTS/src/framework/xexml -I../../third_party/VK-GL-CTS/src/modules/gles2 -I../../third_party/VK-GL-CTS/src/modules/gles2/functional -I../../third_party/VK-GL-CTS/src/modules/gles2/accuracy -I../../third_party/VK-GL-CTS/src/modules/gles2/performance -I../../third_party/VK-GL-CTS/src/modules/gles2/stress -I../../third_party/VK-GL-CTS/src/modules/gles2/usecases -I../../third_party/VK-GL-CTS/src/modules/gles3 -I../../third_party/VK-GL-CTS/src/modules/gles3/functional -I../../third_party/VK-GL-CTS/src/modules/gles3/accuracy -I../../third_party/VK-GL-CTS/src/modules/gles3/performance -I../../third_party/VK-GL-CTS/src/modules/gles3/stress -I../../third_party/VK-GL-CTS/src/modules/gles3/usecases -I../../third_party/VK-GL-CTS/src/modules/gles31 -I../../third_party/VK-GL-CTS/src/modules/gles31/functional -I../../third_party/VK-GL-CTS/src/modules/gles31/stress -I../../third_party/VK-GL-CTS/src/modules/glusecases -I../../third_party/VK-GL-CTS/src/modules/egl -I../../third_party/vulkan-deps/glslang/src -I../../third_party/vulkan-deps/spirv-tools/src -I../../third_party/VK-GL-CTS/src/framework/delibs/decpp -I../../third_party/VK-GL-CTS/src/framework/delibs/debase -I../../third_party/VK-GL-CTS/src/framework/delibs/depool -I../../third_party/VK-GL-CTS/src/framework/delibs/dethread -I../../third_party/VK-GL-CTS/src/framework/delibs/deutil -I../../third_party/VK-GL-CTS/src/framework/delibs/destream -I../../third_party/VK-GL-CTS/src/framework/qphelper -I../../third_party/libpng/src -I../../third_party/VK-GL-CTS/src/modules/glshared -I../../third_party/vulkan-deps/spirv-tools/src/include -Wno-nonportable-include-path -fno-delete-null-pointer-checks -fno-ident -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -fcomplete-member-pointers /Gy /FS /bigobj /utf-8 /Zc:twoPhase /Zc:sizedDealloc- /D__WRL_ENABLE_FUNCTION_STATICS__ -fmsc-version=1916 /Zc:dllexportInlines- -m32 -msse3 /Brepro -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. -no-canonical-prefixes /Od /Ob0 /GF /Z7 -gcodeview-ghash -Xclang -fuse-ctor-homing -ftrivial-auto-var-init=pattern /guard:cf,nochecks /MDd -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-header-hygiene /W3 /wd4800 /wd4267 -Wno-unused-variable -Wno-c++11-narrowing -Wno-unused-but-set-variable -Wno-misleading-indentation /WX -Wno-missing-field-initializers -Wno-unused-parameter -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-nonportable-include-path -Wno-null-pointer-subtraction -Wenum-compare-conditional -Wno-psabi -Wno-ignored-pragma-optimize -Wmax-tokens -Wno-tautological-constant-out-of-range-compare -Wno-conversion -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -Wno-trigraphs /TP -I../../buildtools/third_party/libc++/trunk/include -Wno-sizeof-array-div -Wno-string-conversion -Wno-unused-function -Wno-unused-local-typedef -Wno-unused-result /EHsc /Fd"obj/src/tests/angle_deqp_khr_common_cc.pdb"
In file included from ../../third_party/VK-GL-CTS/src/external/openglcts/modules/common/glcSpirvUtils.cpp:32:
In file included from ../../third_party/vulkan-deps/glslang/src\SPIRV/GlslangToSpv.h:42:
In file included from ../../third_party/vulkan-deps/glslang/src\SPIRV/SpvTools.h:50:
In file included from ../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/localintermediate.h:42:
In file included from ../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/intermediate.h:56:
../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/../Include/Common.h(308,13): error: use of undeclared identifier '_fpclass'; did you mean '_fdclass'?
    switch (_fpclass(x)) {
            ^~~~~~~~
            _fdclass
../../third_party/depot_tools/win_toolchain/vs_files/3bda71a11e\Windows Kits\10\Include\10.0.19041.0\ucrt\corecrt_math.h(173,39): note: '_fdclass' declared here
_Check_return_ _ACRTIMP short __cdecl _fdclass(_In_ float _X);
                                      ^
In file included from ../../third_party/VK-GL-CTS/src/external/openglcts/modules/common/glcSpirvUtils.cpp:32:
In file included from ../../third_party/vulkan-deps/glslang/src\SPIRV/GlslangToSpv.h:42:
In file included from ../../third_party/vulkan-deps/glslang/src\SPIRV/SpvTools.h:50:
In file included from ../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/localintermediate.h:42:
In file included from ../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/intermediate.h:56:
../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/../Include/Common.h(309,10): error: use of undeclared identifier '_FPCLASS_NINF'
    case _FPCLASS_NINF:
         ^
../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/../Include/Common.h(310,10): error: use of undeclared identifier '_FPCLASS_PINF'
    case _FPCLASS_PINF:
         ^
../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/../Include/Common.h(322,13): error: use of undeclared identifier '_fpclass'; did you mean '_fdclass'?
    switch (_fpclass(x)) {
            ^~~~~~~~
            _fdclass
../../third_party/depot_tools/win_toolchain/vs_files/3bda71a11e\Windows Kits\10\Include\10.0.19041.0\ucrt\corecrt_math.h(173,39): note: '_fdclass' declared here
_Check_return_ _ACRTIMP short __cdecl _fdclass(_In_ float _X);
                                      ^
In file included from ../../third_party/VK-GL-CTS/src/external/openglcts/modules/common/glcSpirvUtils.cpp:32:
In file included from ../../third_party/vulkan-deps/glslang/src\SPIRV/GlslangToSpv.h:42:
In file included from ../../third_party/vulkan-deps/glslang/src\SPIRV/SpvTools.h:50:
In file included from ../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/localintermediate.h:42:
In file included from ../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/intermediate.h:56:
../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/../Include/Common.h(323,10): error: use of undeclared identifier '_FPCLASS_SNAN'
    case _FPCLASS_SNAN:
         ^
../../third_party/vulkan-deps/glslang/src\glslang/MachineIndependent/../Include/../Include/Common.h(324,10): error: use of undeclared identifier '_FPCLASS_QNAN'
    case _FPCLASS_QNAN:
         ^
6 errors generated.

From this CL:

d1ee644

Link to failing CL in ANGLE: https://chromium-review.googlesource.com/c/angle/angle/+/3272279
Link to ANGLE issue: http://anglebug.com/6681

[null77]

@mhillenbrand any chance of a revert or quick fix?

[greg-lunarg]

I am initiating a revert.

[greg-lunarg]

Fixed with #2809 which reverts #2803

[mhillenbrand]

Whoops. Sorry for that.

[null77]

Thanks for the quick action!