-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GL values for ARRAY_BUFFER and ELEMENT_ARRAY_BUFFER #170
Comments
Likewise, we should use GL enum values for the primitive type. "primitives": [
{
"indices": "indices_21",
"material": "blinn3-fx",
"primitive": "TRIANGLES", From the WebGL spec: const GLenum POINTS = 0x0000;
const GLenum LINES = 0x0001;
const GLenum LINE_LOOP = 0x0002;
const GLenum LINE_STRIP = 0x0003;
const GLenum TRIANGLES = 0x0004;
const GLenum TRIANGLE_STRIP = 0x0005;
const GLenum TRIANGLE_FAN = 0x0006; |
That's done on master no ? Or at least on dev-2 |
It's not in master, or at least not in the example models. Sorry, I'm not brave enough to develop against dev-2. |
This is fixed in master, but the example models were not updated. This is sloppy of us. We need to keep these in sync so we know what changes version to version. Diffing the examples is the very first thing I do when updating the converter. |
Also, |
Ok, let's keep it for that then |
Yes, about updating models... obviously my bad... I'll update then as soon as I can. |
same here, fixed on dev-2. |
now on master. |
This may already been a known issue, but these should be the GL enum values, not strings:
From the WebGL spec:
The text was updated successfully, but these errors were encountered: