Skip to content
This repository has been archived by the owner on Jul 19, 2018. It is now read-only.

Improve error messages for descriptor mis-matches #1404

Open
tobine opened this issue Jan 24, 2017 · 2 comments
Open

Improve error messages for descriptor mis-matches #1404

tobine opened this issue Jan 24, 2017 · 2 comments
Assignees
Milestone

Comments

@tobine
Copy link
Contributor

tobine commented Jan 24, 2017

Received feedback that the error messages for incompatibility between descriptor layout and pipeline layout could be clearer. Need to make sure which components come from pipeline layout are clearly distinguished from the separate descriptor layout in the error message.

@tobine tobine self-assigned this Jan 24, 2017
@tobine tobine added this to the P2 milestone Jan 24, 2017
@punkUser
Copy link

Just want to add that we definitely would like to see improvements to these descriptor type error messages as well. In particular, the ones that say things like:

Type mismatch on descriptor slot 0.1 (used as type ptr to const uniform image(dim=5, sampled=2)) but descriptor of type VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER

It would be super-useful to know what type of descriptor (enum) it is actually expecting here, as "ptr to const uniform image(dim=5, sampled=2))" is perhaps less useful than you would think :)

@tobine
Copy link
Contributor Author

tobine commented Jul 7, 2017

#1934 addresses my initial concern. I looked at the follow-on request from @punkUser which is a bit trickier. @chrisforbes can you take a look? One possibility I was looking at was to refactor descriptor_type_match() in shader_validation.cpp to use a utility function that would return a vector of acceptable VkDescriptorType values to compare descriptor_type against. The utility function could then also be used to print the acceptable VkDescriptorTypes in the error message. This was a bit messy, though, and I wanted to see if you had a better idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants