Add VK_IMPLICIT_LAYER_PATH & VK_ADD_IMPLICIT_LAYER_PATH env-vars #1550
Conversation
Add the environment variables VK_IMPLICIT_LAYER_PATH and VK_ADD_IMPLICIT_LAYER_PATH to control implicit layer path searching, mirroring the existing explicit layer only VK_LAYER_PATH and VK_ADD_LAYER_PATH. This fixes a gap in environment variable controls over the behavior of the loader.
|
CI Vulkan-Loader build queued with queue ID 253816. |
1 similar comment
|
CI Vulkan-Loader build queued with queue ID 253816. |
|
CI Vulkan-Loader build # 2697 running. |
|
CI Vulkan-Loader build # 2697 passed. |
linyaa-kiwi
changed the title
|
💯 I want this. |
There was a problem hiding this comment.
LGTM. I reviewed the docs and impl. I did not review the tests. All the changes looked correct to me, other than a small nitpick that you can ignore. I'm not a loader codebase export, though, so I don't know if the proposed changes are sufficient.
Also, I was surprised to discover the existing, extensive duplication, verbatim, of much of the loader-application interface. It deserves a cleanup someday, from someone who has the freetime.
charles-lunarg
force-pushed
the
implicit_layer_env_vars
branch
from
447ebda to
3706e39
Compare
|
CI Vulkan-Loader build queued with queue ID 255861. |
|
CI Vulkan-Loader build # 2700 running. |
|
CI Vulkan-Loader build # 2700 passed. |
Add the environment variables VK_IMPLICIT_LAYER_PATH and
VK_ADD_IMPLICIT_LAYER_PATH to control implicit layer path searching,
mirroring the existing explicit layer only VK_LAYER_PATH and
VK_ADD_LAYER_PATH.
This fixes a gap in environment variable controls over the behavior
of the loader.
See issue #1394.