Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration-time search for xrandr headers #1616

Open
MathiasMagnus opened this issue Nov 28, 2024 · 1 comment · May be fixed by #1619
Open

Configuration-time search for xrandr headers #1616

MathiasMagnus opened this issue Nov 28, 2024 · 1 comment · May be fixed by #1619
Labels
enhancement New feature or request

Comments

@MathiasMagnus
Copy link
Contributor

**What enhancement are you suggesting for the Vulkan Loader? Please describe in detail. **

During configuation, when BUILD_WSI_XLIB_SUPPORT is enabled, then pkg_check_modules(X11 REQUIRED QUIET IMPORTED_TARGET x11) searches for headers provided by libx11-dev, but it also set the VK_USE_PLATFORM_XLIB_XRANDR_EXT pre-processor definition. That in turn requires headers from a different package, libxrandr-dev. Missing this last library should not cause a build-time error, but a configuration-time one.

Is this specific to a single platform?
Linux

Additional context

@MathiasMagnus MathiasMagnus added the enhancement New feature or request label Nov 28, 2024
@charles-lunarg
Copy link
Collaborator

Yes, this is a deficiency of the current include setup. I can pretty easily rectify the issue by putting the xrandr stuff in its own if-else block with its own cmake variable to control it. Since it has been required for long time, I will make the default to be "ON" but the new variable will make it easy to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants