tools: Move io utils to cpp #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Context: Going to add a hex reader as an alternative to binary data because sometimes we (myself, @spencer-lunarg) find ourselves with an array of 0x... data and it's annoying not being able to directly read that. Spencer's SPIR-V Visualizer has this, which could be replaced by direct support in spirv-dis for example: https://www.khronos.org/spir/visualizer/ This PR is a refactoring split to keep the hex-reader change smaller. |
In preparation for more code in that file, which would get unwieldy in a header.
Keenuts
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for more code in that file, which would get unwieldy in a header.