Allow fmt arg to printf to be an array of i8 in non-constant space #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic space Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
LU-JOHN
changed the title
svenvh
reviewed
May 22, 2024
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
MrSidims
approved these changes
Jun 19, 2024
This was referenced Jul 10, 2024
|
Hi @alan-baker. Could you please review these changes? Thanks. |
alan-baker
approved these changes
Jul 16, 2024
MrSidims
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 31, 2024
spirv-val allows non-constant and array of 8-bit ints for printf fmt strings after KhronosGroup/SPIRV-Tools#5677. Enable spirv-val testing of this new functionality. Signed-off-by: Lu, John <[email protected]>
Keenuts
pushed a commit
to Keenuts/SPIRV-Tools
that referenced
this pull request
Nov 12, 2024
…hronosGroup#5677) * In spirv-val allow format arg to printf to be an array of i8 in Generic space Signed-off-by: Lu, John <[email protected]> * Allow more addr spaces for printf format string Signed-off-by: Lu, John <[email protected]> * Update printf format arg testcase Signed-off-by: Lu, John <[email protected]> * Apply clang-format Signed-off-by: Lu, John <[email protected]> * Reorder code for clarity Signed-off-by: Lu, John <[email protected]> * Only allow other addr spaces if extension is seen Signed-off-by: Lu, John <[email protected]> * Add test to check printf format with extension Signed-off-by: Lu, John <[email protected]> * Add extension correctly Signed-off-by: Lu, John <[email protected]> --------- Signed-off-by: Lu, John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SPV_EXT_relaxed_printf_string_address_space is enabled llvm-spirv allows the format argument to be in Generic space. Also allow format argument to point to an array of i8 instead of only an i8.
Fixes intel/llvm#11733