Ensure 'printf' is translated to a printf extended insn #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu, John <[email protected]>
|
spirv-val testing in this PR requires changes in KhronosGroup/SPIRV-Tools#5677 |
MrSidims
reviewed
May 23, 2024
test/extensions/EXT/SPV_EXT_relaxed_printf_string_address_space/builtin_printf.ll
Show resolved
Hide resolved
…n in SPIRV Signed-off-by: Lu, John <[email protected]>
MrSidims
approved these changes
May 26, 2024
MrSidims
reviewed
May 26, 2024
svenvh
reviewed
May 27, 2024
test/extensions/EXT/SPV_EXT_relaxed_printf_string_address_space/builtin_printf.ll
Outdated
Show resolved
Hide resolved
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
svenvh
approved these changes
May 29, 2024
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to printf can generated by a user call to __builtin_printf. Represent this in SPIRV with a printf extended insn
instead of a SPIRV call to "printf". A SPIRV call to a variadic function will fail in spirv-val.