Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes in DuckStation emulator #1591

Closed
tycooko opened this issue Jan 11, 2021 · 3 comments · Fixed by #1594
Closed

Crashes in DuckStation emulator #1591

tycooko opened this issue Jan 11, 2021 · 3 comments · Fixed by #1594
Labels
bug Feature which should work in SPIRV-Cross does not for some reason. in progress Issue is being actively worked on

Comments

@tycooko
Copy link

tycooko commented Jan 11, 2021

Hello.
I would like to make this issue noticed: KhronosGroup/MoltenVK#1196 (comment) .
A problem apparently connected to SPIRV-Cross is making DuckStation emulator crash.
@HansKristian-Work HansKristian-Work added the needs triage Needs to be reproduced before it can become a different issue type. label Jan 12, 2021
@HansKristian-Work
Copy link
Contributor

There is indeed an infinite loop and spirv-val passes, weird ...

@HansKristian-Work HansKristian-Work added bug Feature which should work in SPIRV-Cross does not for some reason. in progress Issue is being actively worked on and removed needs triage Needs to be reproduced before it can become a different issue type. labels Jan 14, 2021
@HansKristian-Work
Copy link
Contributor

Fun, pathological case where we get exponential time explosion.

@HansKristian-Work HansKristian-Work mentioned this issue Jan 14, 2021
Merged
@tycooko
Copy link
Author

tycooko commented Jan 15, 2021

Thank you very much, @HansKristian-Work .

Now it's all in your hands, @stenzek ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Feature which should work in SPIRV-Cross does not for some reason. in progress Issue is being actively worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pathological complexity explosion for certain shaders. KhronosGroup/SPIRV-Cross
2 participants
@HansKristian-Work @tycooko