Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK won't build using embedded python #42

Closed
jherico opened this issue May 10, 2019 · 3 comments
Closed

SDK won't build using embedded python #42

jherico opened this issue May 10, 2019 · 3 comments

Comments

@jherico
Copy link
Contributor

jherico commented May 10, 2019

The existing SDK CMake code uses python to generate a number of artifacts, but also uses the PYTHONPATH environment variable to ensure that common modules can be loaded.

However, while trying to create an openxr port for vcpkg, I've discovered that vcpkg provides an embedded version of python. Embedded versions of python from version 3.5.1 and on ignore the PYTHONPATH variable and this is apparently by design.

I'm investigating what needs to happen to make the OpenXR build work with either a conventional Python3 installation or an embedded one.

@rpavlik
Copy link
Contributor

rpavlik commented May 14, 2019

I see you had patches in your vcpkg fork - I'd accept them.

@jherico
Copy link
Contributor Author

jherico commented May 14, 2019

I've opened a PR for the embedded python issue with #46 but I consider the other patch to be a pack, since it hard-codes library names. However I can update my existing PR #44 to use a similar approach but use the find_package(X11) mechanism for the libraries instead of hard-coding them.

@rpavlik
Copy link
Contributor

rpavlik commented May 15, 2019

That would be great if you updated to use find modules. I merged the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants