Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear parent of XrSpace created by xrCreateActionSpace #178

Closed
jzulauf-lunarg opened this issue Nov 4, 2024 · 3 comments
Closed

Unclear parent of XrSpace created by xrCreateActionSpace #178

jzulauf-lunarg opened this issue Nov 4, 2024 · 3 comments
Labels
synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab

Comments

@jzulauf-lunarg
Copy link

The xr.xml defines the parent of XrSpace as the XrSession, but the text states that the XrAction is the parent of the XrSpace created by xrCreateActionSpace for purposes of implicit destruction.

From the registry XrSpace is defined:

<type category="handle" parent="XrSession"><type>XR_DEFINE_HANDLE</type>(<name>XrSpace</name>)</type>

thus be subject to the general

Handles form a hierarchy in which child handles fall under the validity and lifetime of parent handles.

which would imply all XrSpace objects would be destroyed when the parent XrSession is destroy.

In contrast, this body text for xrCreateActionSpace states :

The XrSpace handle must be eventually freed via the xrDestroySpace function or by destroying the parent XrAction handle.

Does this imply that XrSpace created by xrCreateActionSpace remains undestroyed after xrDestroySession is called, and not destroyed as all other XrSpace handles created with xrCreate.*(XrSession session, ...)? Or is it saying the destruction of either the XrAction or the XrSession will cause the implicit destruction of created XrSpace?

@rpavlik
Copy link
Contributor

rpavlik commented Nov 6, 2024

That is an error in the spec, the parent is XrSession for all XrSpace handles. There is text somewhere that says how an action space behaves after destroying the action, iirc.

@rpavlik-bot rpavlik-bot added the synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab label Nov 6, 2024
@rpavlik-bot
Copy link
Collaborator

An issue (number 2395) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2395 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

@rpavlik
Copy link
Contributor

rpavlik commented Nov 27, 2024

Fixed in the latest release. Thanks for the report!

@rpavlik rpavlik closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab
Projects
None yet
Development

No branches or pull requests

3 participants