Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal links broken in 1.1.36 PDF #170

Closed
amalon opened this issue May 18, 2024 · 6 comments
Closed

Internal links broken in 1.1.36 PDF #170

amalon opened this issue May 18, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@amalon
Copy link

amalon commented May 18, 2024

In xrspec.pdf 1.1.36, none of the internal links (e.g. contents page, links to functions like xrWaitFrame) seem to work.
https://registry.khronos.org/OpenXR/specs/1.1/pdf/xrspec.pdf

In 1.0.34 they work fine.
https://registry.khronos.org/OpenXR/specs/1.0/pdf/xrspec.pdf

@rpavlik
Copy link
Contributor

rpavlik commented May 20, 2024

oh, yikes! Not sure how that happened. The table of contents in the PDF itself (usually shows in the sidebar) works but I had not tested the links recently.

@rpavlik rpavlik added the bug Something isn't working label May 20, 2024
@rpavlik rpavlik self-assigned this May 22, 2024
@rpavlik
Copy link
Contributor

rpavlik commented May 22, 2024

OK, so when I build just a simple no-extensions PDF locally I have links working properly. Now to check the rest of the pipeline.

@rpavlik
Copy link
Contributor

rpavlik commented May 22, 2024

OK, I think an update to the PDF optimizer used is at fault, I've got a fix in place for the next release.

@amalon
Copy link
Author

amalon commented May 22, 2024

Will the pdf on the website be updated? Its surprisingly awkward not being able to navigate around by clicking the function links.
Thanks in any case!

@rpavlik
Copy link
Contributor

rpavlik commented May 22, 2024

Yes, those PDFs will be replaced once the next patch release comes out very soon

@rpavlik
Copy link
Contributor

rpavlik commented May 25, 2024

Fixed in 1.1.37, thanks for the report!

@rpavlik rpavlik closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants