Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete set of output parameters for mp3 coders #112

Open
TeoFilin opened this issue Mar 16, 2019 · 1 comment
Open

Incomplete set of output parameters for mp3 coders #112

TeoFilin opened this issue Mar 16, 2019 · 1 comment
Assignees
Labels
bug enhancement WIP Mark a PR as "Work in progress"

Comments

@TeoFilin
Copy link

This converter has the fastest mp3 coders among media-converters at Google Play.
Still the choice of encoding params seems strange:

  • Libmp3lame is VBR-only (why?! CBR/ABR is usual choice in Lame-MP3; VBR gives artifacts with low bitrate, especially w/o resampling);
  • Libshine is CBR-only (OK for speed), and the slider starts with 45 kbps - which causes the coder to fail (acceptable minimum is 48 kbps);
  • the slider isn't appropriate control for bitrates, since they have discreet set of possible values, which are hard to target precisely (48, 56, 64, ... kbps) - combo-box is better;
  • mp3 coders must support much lower bitrates (I prefer 32 kbps CBR, mono 16 kHz - as compact + compatible + tolerable quality {for speech});
  • lower bitrates of mp3 require resampling (44 kHz -> 16 kHz for 32 kbps mono) - else nasty artifacts appear; some codecs seem to fix this automatically, but maybe here we need manual control for sampling rate.
@simonpham simonpham self-assigned this Mar 16, 2019
@simonpham simonpham added enhancement bug WIP Mark a PR as "Work in progress" labels Mar 16, 2019
@simonpham
Copy link
Collaborator

simonpham commented Apr 11, 2019

TODO:

  • Replace slider with combo-box with a discrete set of bitrate
  • Add 32 kbps options
  • Add Settings option to enable Advanced mode, which gives control of CBR/ABR, resampling,...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement WIP Mark a PR as "Work in progress"
Projects
None yet
Development

No branches or pull requests

2 participants