Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Assingning a previously freed instance when quitting to the main menu while there is a container in proximity #478

Closed
snipercup opened this issue Nov 25, 2024 · 0 comments · Fixed by #489
Assignees
Labels
bug Something isn't working

Comments

@snipercup
Copy link
Collaborator

Steps to reproduce:

  • Go to a mob and kill it. It should drop loot
  • Open the inventory and observe the loot container is visible in the inventory window
  • Press escape and quit to main menu
  • Observe error

The error originates from this line:

for inventory: InventoryStacked in proximityInventories.values():

Which is called from this line:

func _on_inventory_item_removed(item, inventory):

I'm not sure why that last line is called or what is removing items from the inventory. A quick fix would be to check if the game is started or is ending and not call update_accessible_items_list. We might need more diagnosis on the problem before we can come to a proper solution.

It might be because of this line:
https://github.com/Khaligufzel/Dimensionfall/pull/456/files#diff-26149249834a47c9270bbfda64bfd9dc5c7cda14578eace1de0fc26b8461a99aR355

But I'm not really sure.

@snipercup snipercup added the bug Something isn't working label Nov 25, 2024
@snipercup snipercup self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant