[Bug] K10 Pro code does not compile when NKRO disabled

[hbieshaar]

Describe the Bug

In branch wireless_playground, the command

make keychron/k10_pro/ansi/white:default

build a firmware keychron_k10_pro_ansi_white_default.bin, but when in the file keyboards/keychron/k10_pro/info.json line 15 is changed from

        "nkro": true,

to

        "nkro": false,

it no longer builds.

Keyboard Used

K10 Pro

Link to product page (if applicable)

No response

Operating System

Debian Linux 12

qmk doctor Output

Ψ QMK Doctor is checking your environment.
Ψ CLI version: 1.1.6
Ψ QMK home: /home/hb/Documents/wip/keyboards/keychron/qmk_firmware
Ψ Detected Linux (Debian GNU/Linux 12 (bookworm)).
Ψ Git branch: wireless_playground
Ψ Repo version: 0.14.29
⚠ Git has unstashed/uncommitted changes.
⚠ The official repository does not seem to be configured as git remote "upstream".
Ψ CLI installed in virtualenv.
Ψ All dependencies are installed.
Ψ Found arm-none-eabi-gcc version 12.2.1
Ψ Found avr-gcc version 5.4.0
Ψ Found avrdude version 7.1
Ψ Found dfu-programmer version 0.6.1
Ψ Found dfu-util version 0.11
Ψ Submodules are up to date.
Ψ Submodule status:
Ψ - lib/chibios: 2022-09-18 10:01:17 +0000 --  (0e9d558b52)
Ψ - lib/chibios-contrib: 2022-10-03 18:09:41 +0200 --  (bb8356fb)
Ψ - lib/googletest: 2021-06-11 06:37:43 -0700 --  (e2239ee6)
Ψ - lib/lufa: 2022-08-26 12:09:55 +1000 --  (549b97320)
Ψ - lib/vusb: 2022-06-13 09:18:17 +1000 --  (819dbc1)
Ψ - lib/printf: 2022-06-29 23:59:58 +0300 --  (c2e3b4e)
Ψ - lib/pico-sdk: 2022-09-19 18:02:44 +0200 --  (8d56ea3)
Ψ - lib/lvgl: 2022-04-11 04:44:53 -0600 --  (e19410f8)
Ψ QMK is ready to go, but minor problems were found

Is AutoHotKey / Karabiner installed

• AutoHotKey (Windows)
• Karabiner (macOS)

Other keyboard-related software installed

I do not think so

Additional Context

No response

[PeterMortensen]

Re "it no longer builds": What is (the full text of) the error?

Is it the following?

Compiling: keyboards/keychron/bluetooth/bluetooth.c                                                keyboards/keychron/bluetooth/bluetooth.c: In function 'bluetooth_init':
keyboards/keychron/bluetooth/bluetooth.c:107:5: error: 'nkro' undeclared (first use in this function)
  107 |     nkro.bluetooth    = keymap_config.nkro;
      |     ^~~~
keyboards/keychron/bluetooth/bluetooth.c:107:5: note: each undeclared identifier is reported only once for each function it appears in
 [ERRORS]

In that case, I can confirm it. With EBDAA0 (2024-11-29).

It was tested with the ISO RGB variant:

qmk compile -kb keychron/k10_pro/iso/rgb -km via

[hbieshaar]

In my case the line-number is 106, but that is indeed the problem.

The line is compiled because BLUETOOTH_NKRO_ENABLE is defined, and the line is not checked against NKRO_ENABLE being defined. I tried to make the definition of BLUETOOTH_NKRO_ENABLE dependent on NKRO_ENABLE being defined, but it only moved the problem to somewhere else.