Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make perf threshold fail on a certain percentage and not hard comparison <= #59

Open
Karm opened this issue Oct 1, 2021 · 0 comments
Open
Assignees

Comments

@Karm
Copy link
Owner

Karm commented Oct 1, 2021

Test suite reports how big is the difference between a value and its threshold when it fails:

org.opentest4j.AssertionFailedError: 
Application JFR_SMOKE_BUILDER_IMAGE in mode jvm_jfr took 7095 ms to finish, 
which is over 6924 ms threshold by 2%.
 ==> expected: <true> but was: <false>

The decision whether to fail a test should be made based on the percentage, i.e. 2% should not fail the test, rather than on a simple comparison of value to its threshold.

@Karm Karm self-assigned this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant