Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.graalvm.tests.integration.JFRTest.jfrPerfTest fails with latest quarkus main #250

Closed
jerboaa opened this issue Mar 15, 2024 · 4 comments · Fixed by #251
Closed

org.graalvm.tests.integration.JFRTest.jfrPerfTest fails with latest quarkus main #250

jerboaa opened this issue Mar 15, 2024 · 4 comments · Fixed by #251
Assignees

Comments

@jerboaa
Copy link
Collaborator

jerboaa commented Mar 15, 2024

The JFR perf runner seems to no longer compile with quarkus main:

 Error:  Failed to execute goal on project jfr-native-image-performance: Could not resolve dependencies for project org.graalvm.tests.integration:jfr-native-image-performance:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-resteasy-reactive:jar:999-SNAPSHOT -> [Help 1]

See:
https://github.com/graalvm/mandrel/actions/runs/8289954741/job/22688018133#step:11:13726

I believe there was a change in quarkus main which caused this. If we knew the fix, we could apply a similar one.

/cc @Karm

@jerboaa jerboaa changed the title [24.1] org.graalvm.tests.integration.JFRTest.jfrPerfTest fails with latest Graal master and JDK 23+13 org.graalvm.tests.integration.JFRTest.jfrPerfTest fails with latest quarkus main Mar 15, 2024
@jerboaa
Copy link
Collaborator Author

jerboaa commented Mar 15, 2024

@Karm Karm self-assigned this Mar 18, 2024
@jerboaa
Copy link
Collaborator Author

jerboaa commented Mar 19, 2024

We see this failure everywhere now. Please prioritize a fix. Thanks!

@Karm
Copy link
Owner

Karm commented Mar 19, 2024

@jerboaa Ack.

@Karm
Copy link
Owner

Karm commented Mar 20, 2024

The binary is not there, because the Q build fails:

Mandrel: quay.io/quarkus/ubi-quarkus-mandrel-builder-image:jdk-21
Quarkus: 9d6f6335c66

[WARNING] ClassRealm[plugin>io.quarkus:quarkus-maven-plugin:999-SNAPSHOT, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@277050dc]
com.google.inject.CreationException: Unable to create injector, see the following errors:

1) No implementation for io.quarkus.maven.QuarkusBootstrapProvider annotated with interface org.eclipse.sisu.inject.TypeArguments$Implicit was bound.
  Did you mean?
    io.quarkus.maven.QuarkusBootstrapProvider bound  at org.eclipse.sisu.wire.LocatorWiring

  at org.eclipse.sisu.wire.LocatorWiring

1 error

Gonna port the app/see how it goes...

GHA shows:

Failed to execute goal on project jfr-native-image-performance: Could not resolve dependencies for project org.graalvm.tests.integration:jfr-native-image-performance:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-resteasy-reactive:jar:999-SNAPSHOT -> [Help 1]

...and that would look like a simple dependency swap...

EDIT:
I deleted all cached files, rebuilt quarkus with -Prelocations and it works now.

[INFO] Results:
[INFO] 
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0

I will rename the extensions in question and try a new PR.
Those weird CNF things above were apparently artifacts of cached jars on my system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants