Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing cross to close contextual catalog with main branch 0.6.x #130

Closed
apupier opened this issue Feb 20, 2023 · 4 comments
Closed

Missing cross to close contextual catalog with main branch 0.6.x #130

apupier opened this issue Feb 20, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@apupier
Copy link
Member

apupier commented Feb 20, 2023

based on 6e9408e51dade095d9fabf2d6a848714dd6c58f7 Kaoto Ui commit, the cross to close contextual catalog is missing:

image

the cross is available on OperateFirst

@apupier apupier added the bug Something isn't working label Feb 20, 2023
@kahboom
Copy link
Contributor

kahboom commented Feb 21, 2023

We removed it to make the mini catalog cleaner/neater, since you can close it by clicking anywhere outside of it. Did you much prefer it with the cross? I'm not sure why it shows on operate first, I have to check if there is some inconsistency as the mini catalog rendering is different depending on where it is shown.

@apupier
Copy link
Member Author

apupier commented Feb 21, 2023

in VS Code, it is not closing when clicking elsewhere.

EDIT: It is closing when clicking elsewhere. There is "only" a delay of something like 10-15 seconds. Sounds like any actions related to the MiniCatalog is delayed of this time after opening the MiniCatalog. See also #132

@apupier
Copy link
Member Author

apupier commented Feb 21, 2023

Did you much prefer it with the cross?

No opinion. I only noticed the difference and thought I cannot close the catalog due the delay mentioned in previous comment

I'm not sure why it shows on operate first, I have to check if there is some inconsistency as the mini catalog rendering is different depending on where it is shown.

ok, so keeping this issue opened for investigation of both the inconsistency with OperateFirst and the 10-15 seconds delay. Maybe will create separate issue later

@apupier
Copy link
Member Author

apupier commented Feb 27, 2023

reported kaoto-archive/kaoto-ui#1326 for the cross left in some cases.

Will close this issue as the slowness is covered by #132

@apupier apupier closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants