Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Default config tab using id instead of title? #1534

Closed
Delawen opened this issue Mar 22, 2023 · 3 comments · Fixed by #1780 or KaotoIO/kaoto-backend#650
Closed

Default config tab using id instead of title? #1534

Delawen opened this issue Mar 22, 2023 · 3 comments · Fixed by #1780 or KaotoIO/kaoto-backend#650
Assignees
@mmuzikar
Labels
bug Something isn't working step detail Relates to the step detail view
Milestone
1.1.0

Comments

@Delawen
Copy link
Member

Delawen commented Mar 22, 2023

Describe the Bug

It looks like the configuration tab for steps is not using the title for the label of the fields and is instead using the id.

Steps to Reproduce the Bug or Issue

  1. Add a split to a route
  2. Open Config tab
  3. "Step id kaoto" is not the title of the property. The title of the property is "Step ID". Instead, "step-id-kaoto" is the id of the field.
    image

Screenshots or Videos

No response

Platform

  • OS: [Linux]
  • Browser: [Firefox]
  • Version: [0.7.4-dev]
@Delawen Delawen added the bug Something isn't working label Mar 22, 2023
This was referenced Mar 22, 2023
Closed
Open
@kahboom kahboom added the step detail Relates to the step detail view label Apr 6, 2023
@Delawen Delawen added this to the 1.1.0 milestone May 9, 2023
@mmuzikar
Copy link
Contributor

It looks like different steps have different rules for title, for example in direct they start with uppercase, but for split title is the same as the id (except for step-id-kaoto).

Currently the field names are autogenerated by Autoform
The aim is probably to have the title be the source of truth always (is that right?), but a possible workaround to be to set a custom field name only if the title is different from the id. WDYT?

@mmuzikar
Copy link
Contributor

Here's an example of Autoform guessing with ressilience4j:
image
And here's using the titles of the split step:
image

@lordrip
Copy link
Member

lordrip commented May 10, 2023

It looks like different steps have different rules for title, for example in direct they start with uppercase, but for split title is the same as the id (except for step-id-kaoto).

Currently the field names are autogenerated by Autoform The aim is probably to have the title be the source of truth always (is that right?), but a possible workaround to be to set a custom field name only if the title is different from the id. WDYT?

This is surprising 👀, were you able to identify in which cases the ID or the Title is used?

This was referenced May 11, 2023
Merged
Merged
@lordrip lordrip mentioned this issue May 19, 2023
Merged
lordrip added a commit that referenced this issue May 19, 2023
@lordrip
fix(stepsService): Use id instead of title for steps parameters
b7685db 
In the past, the 'id' and 'title' properties from a step were the same.
With the introduction of KaotoIO/kaoto-backend#650, now
those properties are not the same.

On the UI side, the 'title' property was used to build the parameters of the step, so
in combination with the previous fix, this caused step extensions relying upon
on the previous information are no longer working.

The fix is to use the 'id' property form now on

relates to: #1534
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mmuzikar mmuzikar

Labels
bug Something isn't working step detail Relates to the step detail view
Projects
None yet
Milestone
1.1.0
4 participants
@Delawen @kahboom @lordrip @mmuzikar