This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix: Integration CRD: Missing multiple route support #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at test failures
|
igarashitm
force-pushed
the
733
branch
2 times, most recently
from
0626ad2
to
f3b82d2
Compare
Codecov Report
@@ Coverage Diff @@
## main #734 +/- ##
============================================
- Coverage 80.05% 79.79% -0.26%
- Complexity 160 161 +1
============================================
Files 53 54 +1
Lines 2793 2866 +73
Branches 457 474 +17
============================================
+ Hits 2236 2287 +51
- Misses 372 382 +10
- Partials 185 197 +12
|
|
Kudos, SonarCloud Quality Gate passed!
|
Delawen
approved these changes
Jun 30, 2023
This was referenced Jun 30, 2023
lordrip
added a commit
to KaotoIO/kaoto-ui
that referenced
this pull request
Jun 30, 2023
With the introduction of KaotoIO/kaoto-backend#734, the multiple flows support for Integration CRDs is no longer an individual CRD per flow but rather a single CRD with many flows in it. This commit takes that into consideration by updating the fixtures and the associated lines. In addition to that, the editorDeleteLine was refactored to leverage the monaco GoToLine functionality to consistently reach a given line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #733
Now
New routebutton successfully adds a new route inside the existing Integration CRD