Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: don't lose examples on properties #727

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

Delawen
Copy link
Member

@Delawen Delawen commented Jun 28, 2023

Fixes #714

@Delawen Delawen requested a review from a team June 28, 2023 09:08
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #727 (91153c1) into main (5f0b26f) will decrease coverage by 0.77%.
The diff coverage is 31.11%.

❗ Current head 91153c1 differs from pull request most recent head f6b9008. Consider uploading reports for the commit f6b9008 to get more accurate results

@@             Coverage Diff              @@
##               main     #727      +/-   ##
============================================
- Coverage     79.69%   78.93%   -0.77%     
+ Complexity      160      159       -1     
============================================
  Files            54       54              
  Lines          2866     2905      +39     
  Branches        474      488      +14     
============================================
+ Hits           2284     2293       +9     
- Misses          384      406      +22     
- Partials        198      206       +8     
Impacted Files Coverage Δ
...rser/step/camelroute/CamelRestDSLParseCatalog.java 93.75% <ø> (ø)
...ployment/generator/kamelet/KameletRepresenter.java 80.95% <ø> (ø)
...arser/step/camelroute/CamelRouteFileProcessor.java 93.37% <ø> (ø)
...data/parser/step/kamelet/KameletFileProcessor.java 83.13% <ø> (ø)
.../step/parser/kamelet/KameletStepParserService.java 69.66% <30.30%> (-6.42%) ⬇️
...src/main/java/io/kaoto/backend/KamelPopulator.java 88.57% <33.33%> (-1.92%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it also fixing he ther point mentioned in the reported issue:
bean properties is lost and instead property with value null is added. ?
I suspect not given the title of the commit but the fixes #714 leads to think that it is

@igarashitm
Copy link
Contributor

@apupier #724 is the one for bean property

@igarashitm igarashitm enabled auto-merge (rebase) June 28, 2023 18:52
auto-merge was automatically disabled June 28, 2023 19:19

Rebase failed

@Delawen Delawen enabled auto-merge (rebase) June 30, 2023 08:38
auto-merge was automatically disabled June 30, 2023 09:24

Rebase failed

@Delawen
Copy link
Member Author

Delawen commented Jun 30, 2023

How conflicts again? Github, you're kidding me!

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.6% 2.6% Duplication

@Delawen Delawen merged commit d5a8c2b into KaotoIO:main Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kamelet bean properties and /spec/definition/properties/*/example are lost on YAML>JSON
3 participants