This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
617 Fix expression support with native build #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #621 +/- ##
============================================
- Coverage 78.56% 78.47% -0.09%
- Complexity 132 133 +1
============================================
Files 45 45
Lines 2342 2342
Branches 364 364
============================================
- Hits 1840 1838 -2
- Misses 339 341 +2
Partials 163 163 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
igarashitm
reviewed
Apr 7, 2023
api/src/test/java/io/kaoto/backend/api/resource/v1/IntegrationsResourceIT.java
Outdated
Show resolved
Hide resolved
igarashitm
approved these changes
Apr 7, 2023
- it allows to have a non-regression test for KaotoIO#617 issue with expressions - extracted a single test from IntegrationsResourceTest which cannot be launch in Native mode because it is using @Inject to access internal services directly. it allows to inherit the native test class from IntegrationsResourceTest and play all of the existing tests in native part of KaotoIO#617 part of KaotoIO#437 Signed-off-by: Aurélien Pupier <[email protected]>
the Expression related classes were missing from native build; Registered all of them for reflection. It might be possible to be more specific and register a single one. to be investigated and potentially improved in another iteration fixes KaotoIO#617 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
617-investigation
branch
from
ec10c36
to
b06257b
Compare
apupier
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
igarashitm
approved these changes
Apr 7, 2023
Delawen
reviewed
Apr 10, 2023
|
|
||
| import io.quarkus.test.junit.QuarkusIntegrationTest; | ||
|
|
||
| @QuarkusIntegrationTest |
Delawen
approved these changes
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #617
part of #437