Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

feature: Add step ids, if they exist (camel routes) #545

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

Delawen
Copy link
Collaborator

@Delawen Delawen commented Mar 17, 2023

This is the backend side of #526

Now the JSON steps may contain a new attribute called stepId that contains the id of the step.

For example, a call to /v1/integrations may answer something like...

{
  "steps": [
    {
      "name": "as2",
      "type": "START",
      "id": "as2-consumer",
      "kind": "Camel-Connector",
      "title": "AS2",
      "description": "Transfer data securely and reliably using the AS2 protocol (RFC4130).",
      "group": "Camel-Component",
      "parameters": [...],
      "required": [
        "apiName",
        "methodName"
      ],
      "branches": null,
      "minBranches": 0,
      "maxBranches": 0,
      "stepId": "patatas",
      "UUID": null
    }
  ],
  "metadata": null,
  "parameters": null,
  "dsl": "Camel Route"
}

@Delawen Delawen requested a review from a team March 17, 2023 09:12
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #545 (09b54a8) into main (2f6c4a8) will increase coverage by 0.31%.
The diff coverage is 94.73%.

@@             Coverage Diff              @@
##               main     #545      +/-   ##
============================================
+ Coverage     78.73%   79.05%   +0.31%     
  Complexity      132      132              
============================================
  Files            45       45              
  Lines          2262     2277      +15     
  Branches        341      342       +1     
============================================
+ Hits           1781     1800      +19     
+ Misses          319      317       -2     
+ Partials        162      160       -2     
Impacted Files Coverage Δ
...ployment/generator/kamelet/KameletRepresenter.java 89.04% <0.00%> (-0.62%) ⬇️
...src/main/java/io/kaoto/backend/KamelPopulator.java 90.15% <100.00%> (+0.41%) ⬆️
...arser/step/camelroute/CamelRouteFileProcessor.java 94.70% <100.00%> (+0.18%) ⬆️
...data/parser/step/kamelet/KameletFileProcessor.java 81.70% <100.00%> (+1.44%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Delawen
Copy link
Collaborator Author

Delawen commented Mar 17, 2023

Converted the attribute into one of the step parameters, so there's no need for anything special on the frontend.

Aaaand test fail.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@Delawen Delawen enabled auto-merge (rebase) March 20, 2023 09:24
@Delawen Delawen merged commit a3a99bc into kaoto-archive:main Mar 20, 2023
@Delawen Delawen deleted the fix-526 branch March 20, 2023 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants