Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: backend returns 204 against Camel Route JSON with script step #540

Closed
wants to merge 1 commit into from
Closed

Conversation

igarashitm
Copy link
Contributor

Fixes: #529

This makes
Screenshot from 2023-03-16 10-01-18

We'd want a script step extension with the syntax selector.

@igarashitm igarashitm requested a review from a team March 16, 2023 14:03
@igarashitm
Copy link
Contributor Author

wait, I'll strip the unnecessary icon from the JSON

@igarashitm
Copy link
Contributor Author

That didn't help much to make test JSON file smaller. Pity.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #540 (b4d58bc) into main (ff4e484) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head b4d58bc differs from pull request most recent head 63d6e14. Consider uploading reports for the commit 63d6e14 to get more accurate results

@@             Coverage Diff              @@
##               main     #540      +/-   ##
============================================
- Coverage     78.96%   78.81%   -0.15%     
  Complexity      132      132              
============================================
  Files            45       45              
  Lines          2244     2247       +3     
  Branches        336      336              
============================================
- Hits           1772     1771       -1     
+ Misses          318      316       -2     
- Partials        154      160       +6     
Impacted Files Coverage Δ
.../step/parser/kamelet/KameletStepParserService.java 73.28% <100.00%> (-0.37%) ⬇️
...arser/step/camelroute/CamelRouteFileProcessor.java 94.52% <100.00%> (+0.03%) ⬆️
...data/parser/step/kamelet/KameletFileProcessor.java 80.26% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@igarashitm igarashitm enabled auto-merge (rebase) March 16, 2023 14:13
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@igarashitm igarashitm disabled auto-merge March 16, 2023 14:21
@igarashitm
Copy link
Contributor Author

On hold, can't add script from source code editor, seems not enough

@igarashitm igarashitm closed this Mar 16, 2023
@lhein
Copy link

lhein commented Mar 16, 2023

Why is that issue being closed? Isn't it important any more?

@igarashitm
Copy link
Contributor Author

@lhein The issue #529 is still open. This is a pull requset and turned out the fix has to address more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] backend returns 204 against Camel Route JSON with script step
2 participants