Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add an ID to the Integration class to distinguish between flows in the UI #663

Closed
lordrip opened this issue May 17, 2023 · 2 comments · Fixed by #712
Closed

Add an ID to the Integration class to distinguish between flows in the UI #663

lordrip opened this issue May 17, 2023 · 2 comments · Fixed by #712
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Never stale Prevent stale bot from closing this issue
Milestone

Comments

@lordrip
Copy link
Member

lordrip commented May 17, 2023

Currently, there's no flow ID in the Integration class, this means that whenever we sync code from the source code editor, the UI doesn't have a way to distinguish between flows, and therefore, the steps from each flow don't have ID either.

The goal would be for the backend to include a new ID property in the Integration class to distinguish between different flows. If the UI already provides an ID, the backend will use it, otherwise, the backend will create one. This is not relevant at the moment for the YAML code since this new ID will live in the communication channel between the backend - frontend.

In summary:

  • UI to Backend -> We send the ID if available, then the backend will keep it
  • Backend to UI -> Based on what's available, being an existing ID, the current DSL, a timestamp, or metadata.name, it sends it back to the UI
@lordrip
Copy link
Member Author

lordrip commented Jun 15, 2023

Related issue: KaotoIO/kaoto-ui#1910

@Delawen Delawen self-assigned this Jun 26, 2023
@Delawen
Copy link
Member

Delawen commented Jun 26, 2023

What we are going to use as id is the name. But we have to make sure the name is always unique inside the same set of flows.

@Delawen Delawen linked a pull request Jun 26, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Never stale Prevent stale bot from closing this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants