Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show taps in a SFSafariViewController #17

Open
davidgeilfus opened this issue Feb 21, 2018 · 4 comments
Open

Show taps in a SFSafariViewController #17

davidgeilfus opened this issue Feb 21, 2018 · 4 comments

Comments

@davidgeilfus
Copy link

Hi, how can I visualize taps in a SFSafariViewController that is presented programmatically from another view controller? Will I have to use WKWebView instead?

@KaneCheshire
Copy link
Owner

Hey! Good question. Just tried and looks like somehow SFSafariViewController doesn't process taps in a window the same way as regular view controllers. I'll have a look into this and see if there's something I can do, maybe I'll have to swizzle SFSafariViewController or something.

Thanks for letting me know! WKWebView should work but it's more of a pain to set up.

@davidgeilfus
Copy link
Author

Great, thank you very much for the quick answer and the help! Indeed, I'd prefer to avoid having to build a browser “from scratch” using WKWebView if possible. ;)

@KaneCheshire
Copy link
Owner

Sorry I realise this has been sitting here for a while. Trying to keep on top of everything and move house has been a challenge!

@KaneCheshire
Copy link
Owner

So, upon first investigation it appears that SFSafariViewController touch events don't cause the UIWindow it's contained in to receive sendEvent, which is what ShowTime uses. I'll see if there's a way around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants