Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryParameters fields are inaccessible due to 'internal' protection level #39

Open
mflp19 opened this issue Aug 16, 2024 · 2 comments
Open

Comments

@mflp19
Copy link

mflp19 commented Aug 16, 2024

Not sure if an issue or if im just approaching this wrong. but i am unable to use the the queryParameters of the request due to its protection level is internal.

        let customRule: Server.Rule = .custom { request in
            print(request.queryParameters)
            let id = request.queryParameters.first(where: {$0.name == "id"})?.value
            return id == "1"
         }

'name' is inaccessible due to 'internal' protection level
'value' is inaccessible due to 'internal' protection level

@KaneCheshire
Copy link
Owner

Oh no that is definitely an oversight on my part. Can definitely expose those properly. Did you want to try putting a PR together for it? Should be a fairly simple one, if not I will try and get to it

@mflp19
Copy link
Author

mflp19 commented Aug 21, 2024

I think i have solved the issue with the protection level and made a PR #41 with the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants