Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default values for Layout Mode #39

Open
laresbernardo opened this issue Oct 25, 2024 · 3 comments
Open

Change default values for Layout Mode #39

laresbernardo opened this issue Oct 25, 2024 · 3 comments
Labels
graphic-walker graphic-walker level issue (github.com/Kanaries/graphic-walker)

Comments

@laresbernardo
Copy link

Hi! Great package. I'm starting to inspect it and it looks promising.
Is it possible to set a parameter so the Layout Mode is set to Container by default?
Thanks.

@bruceyyu
Copy link
Collaborator

I think it is a question related to graphic-walker, our core vis library. Could you please help evaluate whether we should allow this configuration? @ObservedObserver

@ObservedObserver
Copy link
Member

For Graphic Walker, we should add configuration parameters to control default settings (such as layout mode, stack mode, and aggregation method).
For GWalkR and PyGWalker, particularly in RStudio or Jupyter Notebook environments, it would be more user-friendly to read these settings from global configuration files rather than passing them as parameters. This approach would keep the function calls as clean and simple as possible.
I'll create a task ticket for Graphic Walker with a two-week deadline. Once completed, we can update GWalkR to use the new configuration features from Graphic Walker.

@ObservedObserver ObservedObserver added the graphic-walker graphic-walker level issue (github.com/Kanaries/graphic-walker) label Oct 28, 2024
@islxyqwe
Copy link
Member

@bruceyyu you can pass the defaultConfig prop to GraphicWalker to set the default settings.
it contains same data as config and layout settings in spec.
In this case, you can use

{
    "layout": {
        "size": {
            "mode": "full",
            "width": 384,
            "height": 256
        }
    }
}

to set the default layout mode to container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphic-walker graphic-walker level issue (github.com/Kanaries/graphic-walker)
Projects
None yet
Development

No branches or pull requests

4 participants