Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carb predictions #199

Open
Kalhama opened this issue Nov 21, 2024 · 0 comments
Open

Carb predictions #199

Kalhama opened this issue Nov 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Kalhama
Copy link
Owner

Kalhama commented Nov 21, 2024

Rewrite carb predictions

  • for sparse (observed carbs) data, use static predictions
  • for dense data use dynamic predicitons

static prediction

  • use user reported rate and decay for prediction

dynamic predictions

  • for first 15-30 mins of meal, use static prediction
  • after that use recently observed rate
  • gap the results to if they get too far from reported values

Simplification: This is a simplification to what we used before. I think it does not make sense to write complex carb attribution logic for simultaneous meals, because it will anyway. With simple we allow users to explicitly adjust meal parameters if the predictions go wrong. If we use complex logic users don't understand how it works and don't know how to do that.

Bug fixes: Current release of carb prediction does not work properply. Decay is too fast and carb plotting is broken

Maintainability and refactoring: simpler design allows to simplify the code

@Kalhama Kalhama added the bug Something isn't working label Nov 21, 2024
@Kalhama Kalhama moved this to Todo in Gluwave roadmap Nov 21, 2024
@Kalhama Kalhama moved this from Todo to In Progress in Gluwave roadmap Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

1 participant