From e0eefb00ab6fa62237e8b632e55c45aa3385029c Mon Sep 17 00:00:00 2001 From: Phillip Lovelace Date: Wed, 21 Aug 2024 16:11:12 -0700 Subject: [PATCH 1/2] style(choice): remove incorrect margin styles --- packages/sage-assets/lib/stylesheets/components/_choice.scss | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/sage-assets/lib/stylesheets/components/_choice.scss b/packages/sage-assets/lib/stylesheets/components/_choice.scss index 2e57cc1058..097df4458c 100644 --- a/packages/sage-assets/lib/stylesheets/components/_choice.scss +++ b/packages/sage-assets/lib/stylesheets/components/_choice.scss @@ -141,10 +141,6 @@ $-choice-radio-color-checked-inner: map-get($sage-radio-colors, checked-inner); transition: color map-get($sage-transitions, default); } - pds-icon { - margin-top: var(--icon-top-offset); - } - &.sage-choice--vertical-align-icon-start::#{$-choice-el-icon} { align-self: start; margin-top: var(--icon-top-offset); From 56addf8facfbb58b27f9c5c6c285e39f5bd5aa31 Mon Sep 17 00:00:00 2001 From: Phillip Lovelace Date: Wed, 21 Aug 2024 16:11:51 -0700 Subject: [PATCH 2/2] docs(choice): add additional example without subtext --- .../views/examples/components/choice/_preview.html.erb | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/app/views/examples/components/choice/_preview.html.erb b/docs/app/views/examples/components/choice/_preview.html.erb index 8e6bbc2569..0a79b3470f 100644 --- a/docs/app/views/examples/components/choice/_preview.html.erb +++ b/docs/app/views/examples/components/choice/_preview.html.erb @@ -45,6 +45,15 @@ long_description = "Description with longer text to cause wrapping and make the

Icon Variation

Select any icon to appear to the left of the text.

+<%= sage_component SageChoice, { + target: "example", + text: "Option 1", + type: "icon", + icon: "video-on", + } +%> + +

With additional subtext.

<%= sage_component SageChoice, { target: "example", text: "Option 1",