Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show CKAN badge for mods not added directly through Spacedock #442

Open
drewcassidy opened this issue Mar 27, 2022 · 1 comment
Labels
Area: Backend Related to the Python code that runs inside gunicorn Type: Feature

Comments

@drewcassidy
Copy link

Description (What went wrong?):

Right now the CKAN badge only shows up on mods that were added by clicking the checkbox in spacedock. This could lead to mods showing the badge if the mod couldn't be indexed for whatever reason. It also leads to mods added through other means not showing the badge which could confuse users into thinking its not available from CKAN

Solutions:

  • Just a checkbox, and trust the mod maker

  • Search CKAN for the mods existence in some way

  • A custom field for the CKAN ID in the mods metadata (What would be really cool is a way to do an openin link that opens CKAN and installs the requested mod)

@HebaruSan
Copy link
Contributor

HebaruSan commented Apr 3, 2022

This could lead to mods showing the badge if the mod couldn't be indexed for whatever reason.

This part was already addressed, admins can uncheck the checkbox as of #337.

mods added through other means not showing the badge

This can be handled by an admin checking the checkbox as needed. An automated pull request would be created, but it can simply be ignored and closed in one click.

  • Just a checkbox, and trust the mod maker

I'm not sure what this means. Isn't that the current state? But it's listed under "Solutions"?

@HebaruSan HebaruSan added Area: Backend Related to the Python code that runs inside gunicorn Type: Feature labels Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Related to the Python code that runs inside gunicorn Type: Feature
Projects
None yet
Development

No branches or pull requests

2 participants