Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config-file-parser shouldn't export async function #54

Closed
mvanbrab opened this issue Jan 12, 2021 · 0 comments
Closed

config-file-parser shouldn't export async function #54

mvanbrab opened this issue Jan 12, 2021 · 0 comments
Labels
enhancement New feature or request priority:medium

Comments

@mvanbrab
Copy link
Collaborator

Async is not needed here because there's no await inside the function (except for the code in comments at the bottom of that function).
@pheyvaer pheyvaer added enhancement New feature or request priority:medium labels Mar 24, 2021
@renevds renevds mentioned this issue Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix renevds/walder
2 participants
@mvanbrab @pheyvaer