From 1003f53f689fd3f7bfb4c1634637d22698bfab78 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 14:16:32 +0200 Subject: [PATCH 01/16] chore: upgrade to actions/checkout@v3 --- .github/workflows/devpackpublish.yml | 2 +- .github/workflows/docpublish.yml | 4 +--- .github/workflows/npmpublish-rc.yml | 4 ++-- .github/workflows/npmpublish.yml | 4 ++-- .github/workflows/tests-polkadot-deps.yml | 2 +- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/.github/workflows/devpackpublish.yml b/.github/workflows/devpackpublish.yml index a84bf6c8e..57149522a 100644 --- a/.github/workflows/devpackpublish.yml +++ b/.github/workflows/devpackpublish.yml @@ -16,7 +16,7 @@ jobs: runs-on: ubuntu-latest if: "! startsWith(github.event.head_commit.message, '[CI Skip]') && github.repository == 'kiltprotocol/sdk-js'" steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: # fetch-depth 0 and token needed to push changes on the package.json files back. fetch-depth: 0 diff --git a/.github/workflows/docpublish.yml b/.github/workflows/docpublish.yml index 0e2d9f5e6..e99d09725 100644 --- a/.github/workflows/docpublish.yml +++ b/.github/workflows/docpublish.yml @@ -10,9 +10,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 # If you're using actions/checkout@v2 you must set persist-credentials to false in most cases for the deployment to work correctly. - with: - persist-credentials: false + uses: actions/checkout@v3 - name: Install and Build run: | diff --git a/.github/workflows/npmpublish-rc.yml b/.github/workflows/npmpublish-rc.yml index ece3e6a33..c35b2a8b9 100644 --- a/.github/workflows/npmpublish-rc.yml +++ b/.github/workflows/npmpublish-rc.yml @@ -6,7 +6,7 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: actions/setup-node@v2 with: node-version: 14 @@ -18,7 +18,7 @@ jobs: needs: build runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: actions/setup-node@v2 with: node-version: 14 diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index 7957abf81..d4c7e166b 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -6,7 +6,7 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: actions/setup-node@v2 with: node-version: 14 @@ -18,7 +18,7 @@ jobs: needs: build runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: actions/setup-node@v2 with: node-version: 14 diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index fe4494ed0..fa7c17f71 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -16,7 +16,7 @@ jobs: node-version: [14.x, 16.x] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: ref: master - name: Use Node.js ${{ matrix.node-version }} From cfa0cef1c0754843aa9fb90deda9b7a3e11e7933 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 14:19:22 +0200 Subject: [PATCH 02/16] chore: upgrade to actions/setup-node@v3 --- .github/workflows/devpackpublish.yml | 3 ++- .github/workflows/npmpublish-rc.yml | 6 ++++-- .github/workflows/npmpublish.yml | 6 ++++-- .github/workflows/test-node-candidate.yml | 8 +++++--- .github/workflows/tests-polkadot-deps.yml | 13 +------------ .github/workflows/tests.yml | 7 ++++++- 6 files changed, 22 insertions(+), 21 deletions(-) diff --git a/.github/workflows/devpackpublish.yml b/.github/workflows/devpackpublish.yml index 57149522a..b65a5f7a9 100644 --- a/.github/workflows/devpackpublish.yml +++ b/.github/workflows/devpackpublish.yml @@ -21,9 +21,10 @@ jobs: # fetch-depth 0 and token needed to push changes on the package.json files back. fetch-depth: 0 token: ${{ secrets.REPO_ACCESS_TOKEN }} - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - name: Install dependencies run: yarn install --immutable - name: Bump prerelease version of root package diff --git a/.github/workflows/npmpublish-rc.yml b/.github/workflows/npmpublish-rc.yml index c35b2a8b9..b37d8d8c6 100644 --- a/.github/workflows/npmpublish-rc.yml +++ b/.github/workflows/npmpublish-rc.yml @@ -7,9 +7,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - run: yarn install --immutable - run: yarn build - run: yarn test:ci @@ -19,9 +20,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - name: Install dependencies run: yarn install --immutable - name: Build packages diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index d4c7e166b..c9ca6e226 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -7,9 +7,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - run: yarn install --immutable - run: yarn build - run: yarn test:ci @@ -19,9 +20,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - name: Install dependencies run: yarn install --immutable - name: Build packages diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 742e97a92..173ec0a68 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -51,12 +51,11 @@ jobs: needs: cache_imgs steps: - - name: Log out node version - run: node --version - name: Use Node.js 14 uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - name: Log out node version run: node --version - uses: actions/download-artifact@v2 @@ -103,6 +102,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - uses: actions/download-artifact@v2 with: name: build @@ -126,6 +126,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - uses: actions/download-artifact@v2 with: name: build @@ -145,9 +146,10 @@ jobs: - name: Login to Amazon ECR id: login-ecr uses: aws-actions/amazon-ecr-login@v1 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: '16.x' + cache: 'yarn' - run: basename /packages/sdk-js/dist/ - name: pull node image env: diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index fa7c17f71..ca2d734b9 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -20,20 +20,9 @@ jobs: with: ref: master - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - - name: Get yarn cache directory path - id: yarn-cache-dir-path - run: echo "::set-output name=dir::$(yarn config get cacheFolder)" - - uses: actions/cache@v2 - id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`) - with: - path: ${{ steps.yarn-cache-dir-path.outputs.dir }} - key: ${{ runner.os }}-${{ matrix.node-version }}-updated-dependencies - restore-keys: | - ${{ runner.os }}-${{ matrix.node-version }}-updated-dependencies - ${{ runner.os }}-${{ matrix.node-version }}-yarn- - name: delete yarn.lock run: rm -f yarn.lock diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d0edfbeac..a174d61a0 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -63,6 +63,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - uses: actions/download-artifact@v2 with: name: build @@ -129,6 +130,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - name: Log out node version run: node --version - uses: actions/download-artifact@v2 @@ -175,6 +177,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - uses: actions/download-artifact@v2 with: name: build @@ -206,6 +209,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: 14 + cache: 'yarn' - uses: actions/download-artifact@v2 with: name: build @@ -225,9 +229,10 @@ jobs: - name: Login to Amazon ECR id: login-ecr uses: aws-actions/amazon-ecr-login@v1 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: '16.x' + cache: 'yarn' - run: basename /packages/sdk-js/dist/ - name: pull node image env: From 7291a5689519365ac684bbdbf173db7da74565c5 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 14:31:19 +0200 Subject: [PATCH 03/16] chore: update to actions/cache@v3 --- .github/actions/cached-image-pull/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/cached-image-pull/action.yml b/.github/actions/cached-image-pull/action.yml index e2bb9d822..addb6f7f1 100644 --- a/.github/actions/cached-image-pull/action.yml +++ b/.github/actions/cached-image-pull/action.yml @@ -27,7 +27,7 @@ runs: - name: check image cache id: image-cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ steps.image-file.outputs.path }} key: image-cache-${{ inputs.image }} From 914907f994c39cdc17caf0ee9173217dd4befc8f Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 14:51:04 +0200 Subject: [PATCH 04/16] chore: update to actions/{upload|download}-artifact@v3 --- .github/workflows/test-node-candidate.yml | 12 ++++++------ .github/workflows/tests-polkadot-deps.yml | 6 +++--- .github/workflows/tests.yml | 16 ++++++++-------- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 173ec0a68..b1248860e 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -30,7 +30,7 @@ jobs: - name: zip build run: zip -r build.zip . - name: upload build - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: build path: build.zip @@ -58,7 +58,7 @@ jobs: cache: 'yarn' - name: Log out node version run: node --version - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build - name: unzip @@ -103,7 +103,7 @@ jobs: with: node-version: 14 cache: 'yarn' - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build - name: unzip @@ -111,7 +111,7 @@ jobs: - name: yarn bundle run: yarn bundle - name: upload bundle artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: checked-nonmin-bundle path: packages/sdk-js/dist/sdk-js.umd.js @@ -127,12 +127,12 @@ jobs: with: node-version: 14 cache: 'yarn' - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build - name: unzip run: unzip build.zip -d . - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: checked-nonmin-bundle path: packages/sdk-js/dist diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index ca2d734b9..894c2552d 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -46,7 +46,7 @@ jobs: - name: zip build run: zip -r build.zip . - name: upload build - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: build-${{ matrix.node-version }} path: build.zip @@ -66,7 +66,7 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build-${{ matrix.node-version }} - name: unzip @@ -90,7 +90,7 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build-14.x - name: unzip diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a174d61a0..ddcc0afcb 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -49,7 +49,7 @@ jobs: - name: zip build run: zip -r build.zip . - name: upload build - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: build path: build.zip @@ -64,7 +64,7 @@ jobs: with: node-version: 14 cache: 'yarn' - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build - name: unzip @@ -93,7 +93,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build - name: unzip @@ -133,7 +133,7 @@ jobs: cache: 'yarn' - name: Log out node version run: node --version - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build - name: unzip @@ -178,7 +178,7 @@ jobs: with: node-version: 14 cache: 'yarn' - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build - name: unzip @@ -186,7 +186,7 @@ jobs: - name: yarn bundle run: yarn bundle - name: upload bundle artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: checked-nonmin-bundle path: packages/sdk-js/dist/sdk-js.umd.js @@ -210,12 +210,12 @@ jobs: with: node-version: 14 cache: 'yarn' - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: build - name: unzip run: unzip build.zip -d . - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: checked-nonmin-bundle path: packages/sdk-js/dist From 32938b4345380da57156c3491870c3fc4681741e Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 15:21:54 +0200 Subject: [PATCH 05/16] chore: retire set-output syntax --- .github/actions/cached-image-pull/action.yml | 2 +- .github/workflows/devpackpublish.yml | 2 +- .github/workflows/npmpublish-rc.yml | 2 +- .github/workflows/npmpublish.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/actions/cached-image-pull/action.yml b/.github/actions/cached-image-pull/action.yml index addb6f7f1..351bb3e6a 100644 --- a/.github/actions/cached-image-pull/action.yml +++ b/.github/actions/cached-image-pull/action.yml @@ -23,7 +23,7 @@ runs: env: CACHE_PATH: ${{ inputs.cache-directory }}${{ inputs.cache-file }}.tar run: | - echo "::set-output name=path::$CACHE_PATH" + echo "path=$CACHE_PATH" >> $GITHUB_OUTPUT - name: check image cache id: image-cache diff --git a/.github/workflows/devpackpublish.yml b/.github/workflows/devpackpublish.yml index b65a5f7a9..a976dc9cc 100644 --- a/.github/workflows/devpackpublish.yml +++ b/.github/workflows/devpackpublish.yml @@ -31,7 +31,7 @@ jobs: run: npm version --no-git-tag-version prerelease - name: Get current package version id: package_version - run: echo "::set-output name=package_version::$(node -pe "require('./package.json').version")" + run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT - name: Set all other packages to same version env: PACKAGE_VERSION: ${{ steps.package_version.outputs.package_version }} diff --git a/.github/workflows/npmpublish-rc.yml b/.github/workflows/npmpublish-rc.yml index b37d8d8c6..c53519c74 100644 --- a/.github/workflows/npmpublish-rc.yml +++ b/.github/workflows/npmpublish-rc.yml @@ -32,7 +32,7 @@ jobs: run: yarn run bundle - name: Get current package version id: package_version - run: echo "::set-output name=package_version::$(node -pe "require('./package.json').version")" + run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT - name: Publish to NPM run: yarn run publish --tag rc env: diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index c9ca6e226..7f3123b81 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -32,7 +32,7 @@ jobs: run: yarn run bundle - name: Get current package version id: package_version - run: echo "::set-output name=package_version::$(node -pe "require('./package.json').version")" + run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT - name: Publish to NPM run: yarn run publish --tag latest env: From e5e3e327801824aaacfbd41ee1f5cbd808172586 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 15:36:55 +0200 Subject: [PATCH 06/16] chore: update workflow trigger exceptions logic --- .github/workflows/tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ddcc0afcb..1245c126a 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -13,7 +13,8 @@ on: - 'Dockerfile' - 'docker-compose.yml' - 'dc.build.node.yml' - - '.github/workflows/*publish.yml' + - '.github/**' + - '!.github/workflows/tests.yml' pull_request: branches: - develop From c3caae422bbc515b358d3e7abcf331b291bf129b Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 15:54:05 +0200 Subject: [PATCH 07/16] chore: move setup-node after artifact restore --- .github/workflows/test-node-candidate.yml | 35 ++++++++--------- .github/workflows/tests.yml | 46 ++++++++++------------- 2 files changed, 35 insertions(+), 46 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index b1248860e..2f047ff0f 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -51,6 +51,11 @@ jobs: needs: cache_imgs steps: + - uses: actions/download-artifact@v3 + with: + name: build + - name: unzip + run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -58,11 +63,6 @@ jobs: cache: 'yarn' - name: Log out node version run: node --version - - uses: actions/download-artifact@v3 - with: - name: build - - name: unzip - run: unzip build.zip -d . - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v1 @@ -98,16 +98,16 @@ jobs: needs: build steps: - - name: Use Node.js 14 - uses: actions/setup-node@v3 - with: - node-version: 14 - cache: 'yarn' - uses: actions/download-artifact@v3 with: name: build - name: unzip run: unzip build.zip -d . + - name: Use Node.js 14 + uses: actions/setup-node@v3 + with: + node-version: 14 + cache: 'yarn' - name: yarn bundle run: yarn bundle - name: upload bundle artifact @@ -122,11 +122,6 @@ jobs: needs: [cache_imgs, bundle_cache] steps: - - name: Use Node.js 14 - uses: actions/setup-node@v3 - with: - node-version: 14 - cache: 'yarn' - uses: actions/download-artifact@v3 with: name: build @@ -136,6 +131,11 @@ jobs: with: name: checked-nonmin-bundle path: packages/sdk-js/dist + - uses: actions/setup-node@v3 + with: + node-version: '16.x' + cache: 'yarn' + - run: basename /packages/sdk-js/dist/ - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v1 with: @@ -146,11 +146,6 @@ jobs: - name: Login to Amazon ECR id: login-ecr uses: aws-actions/amazon-ecr-login@v1 - - uses: actions/setup-node@v3 - with: - node-version: '16.x' - cache: 'yarn' - - run: basename /packages/sdk-js/dist/ - name: pull node image env: ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1245c126a..0eb986dc2 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -60,16 +60,16 @@ jobs: needs: build steps: - - name: Use Node.js 14 - uses: actions/setup-node@v3 - with: - node-version: 14 - cache: 'yarn' - uses: actions/download-artifact@v3 with: name: build - name: unzip run: unzip build.zip -d . + - name: Use Node.js 14 + uses: actions/setup-node@v3 + with: + node-version: 14 + cache: 'yarn' - name: lint run: yarn lint - name: check dependency duplication @@ -125,8 +125,11 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - name: Log out node version - run: node --version + - uses: actions/download-artifact@v3 + with: + name: build + - name: unzip + run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -134,11 +137,6 @@ jobs: cache: 'yarn' - name: Log out node version run: node --version - - uses: actions/download-artifact@v3 - with: - name: build - - name: unzip - run: unzip build.zip -d . - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v1 @@ -174,16 +172,16 @@ jobs: needs: build steps: - - name: Use Node.js 14 - uses: actions/setup-node@v3 - with: - node-version: 14 - cache: 'yarn' - uses: actions/download-artifact@v3 with: name: build - name: unzip run: unzip build.zip -d . + - name: Use Node.js 14 + uses: actions/setup-node@v3 + with: + node-version: 14 + cache: 'yarn' - name: yarn bundle run: yarn bundle - name: upload bundle artifact @@ -206,11 +204,6 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - name: Use Node.js 14 - uses: actions/setup-node@v3 - with: - node-version: 14 - cache: 'yarn' - uses: actions/download-artifact@v3 with: name: build @@ -220,6 +213,11 @@ jobs: with: name: checked-nonmin-bundle path: packages/sdk-js/dist + - uses: actions/setup-node@v3 + with: + node-version: '16.x' + cache: 'yarn' + - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v1 with: @@ -230,10 +228,6 @@ jobs: - name: Login to Amazon ECR id: login-ecr uses: aws-actions/amazon-ecr-login@v1 - - uses: actions/setup-node@v3 - with: - node-version: '16.x' - cache: 'yarn' - run: basename /packages/sdk-js/dist/ - name: pull node image env: From 25f19cb3ae8386a9f0f15aaa6129400c851b8da4 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 16:05:40 +0200 Subject: [PATCH 08/16] chore: update aws-actions/configure-aws-credentials --- .github/workflows/test-node-candidate.yml | 4 ++-- .github/workflows/tests-polkadot-deps.yml | 2 +- .github/workflows/tests.yml | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 2f047ff0f..0ca930978 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -65,7 +65,7 @@ jobs: run: node --version - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v1 + uses: aws-actions/configure-aws-credentials@v2 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} @@ -137,7 +137,7 @@ jobs: cache: 'yarn' - run: basename /packages/sdk-js/dist/ - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v1 + uses: aws-actions/configure-aws-credentials@v2 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index 894c2552d..4a003c7b1 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -97,7 +97,7 @@ jobs: run: unzip build.zip -d . - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v1 + uses: aws-actions/configure-aws-credentials@v2 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 0eb986dc2..d2fe894ba 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -139,7 +139,7 @@ jobs: run: node --version - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v1 + uses: aws-actions/configure-aws-credentials@v2 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} @@ -219,7 +219,7 @@ jobs: cache: 'yarn' - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v1 + uses: aws-actions/configure-aws-credentials@v2 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} From 4ac17a5fa536660c4f8f7f4e227a2122a4ef64a6 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 16:14:33 +0200 Subject: [PATCH 09/16] chore: upgrade JamesIves/github-pages-deploy-action --- .github/workflows/docpublish.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docpublish.yml b/.github/workflows/docpublish.yml index e99d09725..6d075f62a 100644 --- a/.github/workflows/docpublish.yml +++ b/.github/workflows/docpublish.yml @@ -18,8 +18,7 @@ jobs: yarn build:docs - name: Deploy - uses: JamesIves/github-pages-deploy-action@releases/v3 + uses: JamesIves/github-pages-deploy-action@v4 with: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - BRANCH: gh-pages # The branch the action should deploy to. - FOLDER: docs/api # The folder the action should deploy to. + branch: gh-pages # The branch the action should deploy to. + folder: docs/api # The folder the action should deploy to. From f97dce744aa35533622ea3a331a12e220a9cf253 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 16:16:54 +0200 Subject: [PATCH 10/16] chore: update amannn/action-semantic-pull-request --- .github/workflows/semantic-pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/semantic-pull-request.yml b/.github/workflows/semantic-pull-request.yml index 06d2d32d3..c4ba39bf9 100644 --- a/.github/workflows/semantic-pull-request.yml +++ b/.github/workflows/semantic-pull-request.yml @@ -11,6 +11,6 @@ jobs: validate: runs-on: ubuntu-latest steps: - - uses: amannn/action-semantic-pull-request@v4 + - uses: amannn/action-semantic-pull-request@v5 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 436bca83d5ab64bc9eaf56e6282ca83760739a82 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 16:28:09 +0200 Subject: [PATCH 11/16] refactor: don't zip --- .github/workflows/test-node-candidate.yml | 10 +--------- .github/workflows/tests-polkadot-deps.yml | 8 +------- .github/workflows/tests.yml | 14 +------------- 3 files changed, 3 insertions(+), 29 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 0ca930978..17584cfcf 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -27,13 +27,11 @@ jobs: run: yarn install --immutable - name: yarn build run: yarn build - - name: zip build - run: zip -r build.zip . - name: upload build uses: actions/upload-artifact@v3 with: name: build - path: build.zip + path: ./ cache_imgs: runs-on: ubuntu-latest @@ -54,8 +52,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build - - name: unzip - run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -101,8 +97,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build - - name: unzip - run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -125,8 +119,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build - - name: unzip - run: unzip build.zip -d . - uses: actions/download-artifact@v3 with: name: checked-nonmin-bundle diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index 4a003c7b1..ac3554c5a 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -43,13 +43,11 @@ jobs: - name: yarn build run: yarn build - - name: zip build - run: zip -r build.zip . - name: upload build uses: actions/upload-artifact@v3 with: name: build-${{ matrix.node-version }} - path: build.zip + path: ./ test: runs-on: ubuntu-latest @@ -69,8 +67,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build-${{ matrix.node-version }} - - name: unzip - run: unzip build.zip -d . - name: unit tests run: yarn test:ci @@ -93,8 +89,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build-14.x - - name: unzip - run: unzip build.zip -d . - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v2 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d2fe894ba..de4a4a660 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -47,13 +47,11 @@ jobs: run: yarn install --immutable - name: yarn build run: yarn build - - name: zip build - run: zip -r build.zip . - name: upload build uses: actions/upload-artifact@v3 with: name: build - path: build.zip + path: ./ lint: runs-on: ubuntu-latest @@ -63,8 +61,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build - - name: unzip - run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -97,8 +93,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build - - name: unzip - run: unzip build.zip -d . - name: unit tests run: yarn test:ci @@ -128,8 +122,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build - - name: unzip - run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -175,8 +167,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build - - name: unzip - run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -207,8 +197,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: build - - name: unzip - run: unzip build.zip -d . - uses: actions/download-artifact@v3 with: name: checked-nonmin-bundle From 9ff9597647aa5d311c0b3832b22b9fd2843f4e1b Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Mon, 3 Apr 2023 16:46:12 +0200 Subject: [PATCH 12/16] Revert "refactor: don't zip" This reverts commit 436bca83d5ab64bc9eaf56e6282ca83760739a82. --- .github/workflows/test-node-candidate.yml | 10 +++++++++- .github/workflows/tests-polkadot-deps.yml | 8 +++++++- .github/workflows/tests.yml | 14 +++++++++++++- 3 files changed, 29 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 17584cfcf..0ca930978 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -27,11 +27,13 @@ jobs: run: yarn install --immutable - name: yarn build run: yarn build + - name: zip build + run: zip -r build.zip . - name: upload build uses: actions/upload-artifact@v3 with: name: build - path: ./ + path: build.zip cache_imgs: runs-on: ubuntu-latest @@ -52,6 +54,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build + - name: unzip + run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -97,6 +101,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build + - name: unzip + run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -119,6 +125,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build + - name: unzip + run: unzip build.zip -d . - uses: actions/download-artifact@v3 with: name: checked-nonmin-bundle diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index ac3554c5a..4a003c7b1 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -43,11 +43,13 @@ jobs: - name: yarn build run: yarn build + - name: zip build + run: zip -r build.zip . - name: upload build uses: actions/upload-artifact@v3 with: name: build-${{ matrix.node-version }} - path: ./ + path: build.zip test: runs-on: ubuntu-latest @@ -67,6 +69,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build-${{ matrix.node-version }} + - name: unzip + run: unzip build.zip -d . - name: unit tests run: yarn test:ci @@ -89,6 +93,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build-14.x + - name: unzip + run: unzip build.zip -d . - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v2 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index de4a4a660..d2fe894ba 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -47,11 +47,13 @@ jobs: run: yarn install --immutable - name: yarn build run: yarn build + - name: zip build + run: zip -r build.zip . - name: upload build uses: actions/upload-artifact@v3 with: name: build - path: ./ + path: build.zip lint: runs-on: ubuntu-latest @@ -61,6 +63,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build + - name: unzip + run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -93,6 +97,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build + - name: unzip + run: unzip build.zip -d . - name: unit tests run: yarn test:ci @@ -122,6 +128,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build + - name: unzip + run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -167,6 +175,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build + - name: unzip + run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: @@ -197,6 +207,8 @@ jobs: - uses: actions/download-artifact@v3 with: name: build + - name: unzip + run: unzip build.zip -d . - uses: actions/download-artifact@v3 with: name: checked-nonmin-bundle From c709d397edf02439da03e0b2b05cfa03723e9fc0 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Tue, 4 Apr 2023 10:41:35 +0200 Subject: [PATCH 13/16] chore: only use caching where install follows --- .github/workflows/test-node-candidate.yml | 27 ++++++++--------- .github/workflows/tests-polkadot-deps.yml | 1 + .github/workflows/tests.yml | 36 ++++++++++------------- 3 files changed, 29 insertions(+), 35 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 0ca930978..b9b73eb25 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -51,18 +51,17 @@ jobs: needs: cache_imgs steps: - - uses: actions/download-artifact@v3 - with: - name: build - - name: unzip - run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: node-version: 14 - cache: 'yarn' - name: Log out node version run: node --version + - uses: actions/download-artifact@v3 + with: + name: build + - name: unzip + run: unzip build.zip -d . - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v2 @@ -98,16 +97,15 @@ jobs: needs: build steps: + - name: Use Node.js 14 + uses: actions/setup-node@v3 + with: + node-version: 14 - uses: actions/download-artifact@v3 with: name: build - name: unzip run: unzip build.zip -d . - - name: Use Node.js 14 - uses: actions/setup-node@v3 - with: - node-version: 14 - cache: 'yarn' - name: yarn bundle run: yarn bundle - name: upload bundle artifact @@ -122,6 +120,9 @@ jobs: needs: [cache_imgs, bundle_cache] steps: + - uses: actions/setup-node@v3 + with: + node-version: '16.x' - uses: actions/download-artifact@v3 with: name: build @@ -131,10 +132,6 @@ jobs: with: name: checked-nonmin-bundle path: packages/sdk-js/dist - - uses: actions/setup-node@v3 - with: - node-version: '16.x' - cache: 'yarn' - run: basename /packages/sdk-js/dist/ - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v2 diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index 4a003c7b1..b83dd2869 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -23,6 +23,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} + cache: 'yarn' - name: delete yarn.lock run: rm -f yarn.lock diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d2fe894ba..c7efd13e7 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -60,16 +60,15 @@ jobs: needs: build steps: + - name: Use Node.js 14 + uses: actions/setup-node@v3 + with: + node-version: 14 - uses: actions/download-artifact@v3 with: name: build - name: unzip run: unzip build.zip -d . - - name: Use Node.js 14 - uses: actions/setup-node@v3 - with: - node-version: 14 - cache: 'yarn' - name: lint run: yarn lint - name: check dependency duplication @@ -125,18 +124,17 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - uses: actions/download-artifact@v3 - with: - name: build - - name: unzip - run: unzip build.zip -d . - name: Use Node.js 14 uses: actions/setup-node@v3 with: node-version: 14 - cache: 'yarn' - name: Log out node version run: node --version + - uses: actions/download-artifact@v3 + with: + name: build + - name: unzip + run: unzip build.zip -d . - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v2 @@ -172,16 +170,15 @@ jobs: needs: build steps: + - name: Use Node.js 14 + uses: actions/setup-node@v3 + with: + node-version: 14 - uses: actions/download-artifact@v3 with: name: build - name: unzip run: unzip build.zip -d . - - name: Use Node.js 14 - uses: actions/setup-node@v3 - with: - node-version: 14 - cache: 'yarn' - name: yarn bundle run: yarn bundle - name: upload bundle artifact @@ -204,6 +201,9 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: + - uses: actions/setup-node@v3 + with: + node-version: '16.x' - uses: actions/download-artifact@v3 with: name: build @@ -213,10 +213,6 @@ jobs: with: name: checked-nonmin-bundle path: packages/sdk-js/dist - - uses: actions/setup-node@v3 - with: - node-version: '16.x' - cache: 'yarn' - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v2 From 90e992c2fc0e7f6604c81514b90928fac859ebd3 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Wed, 5 Apr 2023 16:18:25 +0200 Subject: [PATCH 14/16] ci: use nvmrc version for ci jobs --- .github/workflows/devpackpublish.yml | 2 +- .github/workflows/npmpublish-rc.yml | 4 ++-- .github/workflows/npmpublish.yml | 4 ++-- .github/workflows/test-node-candidate.yml | 8 ++++---- .github/workflows/tests.yml | 10 +++++----- .nvmrc | 2 +- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/devpackpublish.yml b/.github/workflows/devpackpublish.yml index a976dc9cc..775829df7 100644 --- a/.github/workflows/devpackpublish.yml +++ b/.github/workflows/devpackpublish.yml @@ -23,7 +23,7 @@ jobs: token: ${{ secrets.REPO_ACCESS_TOKEN }} - uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' cache: 'yarn' - name: Install dependencies run: yarn install --immutable diff --git a/.github/workflows/npmpublish-rc.yml b/.github/workflows/npmpublish-rc.yml index c53519c74..32757d77c 100644 --- a/.github/workflows/npmpublish-rc.yml +++ b/.github/workflows/npmpublish-rc.yml @@ -9,7 +9,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' cache: 'yarn' - run: yarn install --immutable - run: yarn build @@ -22,7 +22,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' cache: 'yarn' - name: Install dependencies run: yarn install --immutable diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index 7f3123b81..69f679d51 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -9,7 +9,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' cache: 'yarn' - run: yarn install --immutable - run: yarn build @@ -22,7 +22,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' cache: 'yarn' - name: Install dependencies run: yarn install --immutable diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index b9b73eb25..767e524ea 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -21,7 +21,7 @@ jobs: - name: Use Node.js 14 uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' cache: 'yarn' - name: yarn install run: yarn install --immutable @@ -54,7 +54,7 @@ jobs: - name: Use Node.js 14 uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' - name: Log out node version run: node --version - uses: actions/download-artifact@v3 @@ -100,7 +100,7 @@ jobs: - name: Use Node.js 14 uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' - uses: actions/download-artifact@v3 with: name: build @@ -122,7 +122,7 @@ jobs: steps: - uses: actions/setup-node@v3 with: - node-version: '16.x' + node-version-file: '.nvmrc' - uses: actions/download-artifact@v3 with: name: build diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index c7efd13e7..c929d216d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -41,7 +41,7 @@ jobs: - name: Use Node.js 14 uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' cache: 'yarn' - name: yarn install run: yarn install --immutable @@ -63,7 +63,7 @@ jobs: - name: Use Node.js 14 uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' - uses: actions/download-artifact@v3 with: name: build @@ -127,7 +127,7 @@ jobs: - name: Use Node.js 14 uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' - name: Log out node version run: node --version - uses: actions/download-artifact@v3 @@ -173,7 +173,7 @@ jobs: - name: Use Node.js 14 uses: actions/setup-node@v3 with: - node-version: 14 + node-version-file: '.nvmrc' - uses: actions/download-artifact@v3 with: name: build @@ -203,7 +203,7 @@ jobs: steps: - uses: actions/setup-node@v3 with: - node-version: '16.x' + node-version-file: '.nvmrc' - uses: actions/download-artifact@v3 with: name: build diff --git a/.nvmrc b/.nvmrc index b009dfb9d..853c0e122 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -lts/* +lts/Hydrogen From 753cc8428247564e7b282188407d518abfbfb08e Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Wed, 5 Apr 2023 16:21:53 +0200 Subject: [PATCH 15/16] chore: update setup-node step description --- .github/workflows/test-node-candidate.yml | 6 +++--- .github/workflows/tests.yml | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 767e524ea..21305c35a 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -18,7 +18,7 @@ jobs: steps: - uses: actions/checkout@v3 - - name: Use Node.js 14 + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version-file: '.nvmrc' @@ -51,7 +51,7 @@ jobs: needs: cache_imgs steps: - - name: Use Node.js 14 + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version-file: '.nvmrc' @@ -97,7 +97,7 @@ jobs: needs: build steps: - - name: Use Node.js 14 + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version-file: '.nvmrc' diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index c929d216d..f489fd02f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -38,7 +38,7 @@ jobs: steps: - uses: actions/checkout@v3 - - name: Use Node.js 14 + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version-file: '.nvmrc' @@ -60,7 +60,7 @@ jobs: needs: build steps: - - name: Use Node.js 14 + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version-file: '.nvmrc' @@ -124,7 +124,7 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - name: Use Node.js 14 + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version-file: '.nvmrc' @@ -170,7 +170,7 @@ jobs: needs: build steps: - - name: Use Node.js 14 + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version-file: '.nvmrc' From 308fe7b02592f0034de67a56edaa84c42bbdb0d2 Mon Sep 17 00:00:00 2001 From: Raphael Flechtner Date: Wed, 5 Apr 2023 16:56:44 +0200 Subject: [PATCH 16/16] Revert "ci: use nvmrc version for ci jobs" This reverts commit 90e992c2fc0e7f6604c81514b90928fac859ebd3. --- .github/workflows/devpackpublish.yml | 2 +- .github/workflows/npmpublish-rc.yml | 4 ++-- .github/workflows/npmpublish.yml | 4 ++-- .github/workflows/test-node-candidate.yml | 8 ++++---- .github/workflows/tests.yml | 10 +++++----- .nvmrc | 2 +- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/devpackpublish.yml b/.github/workflows/devpackpublish.yml index 775829df7..a976dc9cc 100644 --- a/.github/workflows/devpackpublish.yml +++ b/.github/workflows/devpackpublish.yml @@ -23,7 +23,7 @@ jobs: token: ${{ secrets.REPO_ACCESS_TOKEN }} - uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 cache: 'yarn' - name: Install dependencies run: yarn install --immutable diff --git a/.github/workflows/npmpublish-rc.yml b/.github/workflows/npmpublish-rc.yml index 32757d77c..c53519c74 100644 --- a/.github/workflows/npmpublish-rc.yml +++ b/.github/workflows/npmpublish-rc.yml @@ -9,7 +9,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 cache: 'yarn' - run: yarn install --immutable - run: yarn build @@ -22,7 +22,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 cache: 'yarn' - name: Install dependencies run: yarn install --immutable diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index 69f679d51..7f3123b81 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -9,7 +9,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 cache: 'yarn' - run: yarn install --immutable - run: yarn build @@ -22,7 +22,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 cache: 'yarn' - name: Install dependencies run: yarn install --immutable diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 21305c35a..6276ffd4c 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -21,7 +21,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 cache: 'yarn' - name: yarn install run: yarn install --immutable @@ -54,7 +54,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 - name: Log out node version run: node --version - uses: actions/download-artifact@v3 @@ -100,7 +100,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 - uses: actions/download-artifact@v3 with: name: build @@ -122,7 +122,7 @@ jobs: steps: - uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: '16.x' - uses: actions/download-artifact@v3 with: name: build diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f489fd02f..3b83fb704 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -41,7 +41,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 cache: 'yarn' - name: yarn install run: yarn install --immutable @@ -63,7 +63,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 - uses: actions/download-artifact@v3 with: name: build @@ -127,7 +127,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 - name: Log out node version run: node --version - uses: actions/download-artifact@v3 @@ -173,7 +173,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: 14 - uses: actions/download-artifact@v3 with: name: build @@ -203,7 +203,7 @@ jobs: steps: - uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version: '16.x' - uses: actions/download-artifact@v3 with: name: build diff --git a/.nvmrc b/.nvmrc index 853c0e122..b009dfb9d 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -lts/Hydrogen +lts/*